third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js b/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

index 05914662f736aab0adc35b3fbef33c3a7ae82e14..35d99109b98cfd99cdae573671c3c26c5d70bb9e 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

@@ -82,7 +82,7 @@ WebInspector.RenderingOptionsView = function()

this._mediaSelect.addEventListener("change", this._mediaToggled.bind(this), false);

this._mediaSelect.disabled = true;

- WebInspector.targetManager.observeTargets(this, WebInspector.Target.Type.Page);

+ WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capability.Browser);

}

WebInspector.RenderingOptionsView.prototype = {

@@ -108,9 +108,8 @@ WebInspector.RenderingOptionsView.prototype = {

_settingToggled: function(setterName)

{

var enabled = this._settings.get(setterName).checked;

- var targets = WebInspector.targetManager.targets(WebInspector.Target.Type.Page);

- for (var i = 0; i < targets.length; ++i)

- targets[i].renderingAgent()[setterName](enabled);

+ for (var target of WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser))

+ target.renderingAgent()[setterName](enabled);

/**

@@ -130,7 +129,7 @@ WebInspector.RenderingOptionsView.prototype = {

_mediaToggled: function()

{

this._mediaSelect.disabled = !this._mediaCheckbox.checked;

- var targets = WebInspector.targetManager.targets(WebInspector.Target.Type.Page);

+ var targets = WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser);

for (var target of targets)

this._applyPrintMediaOverride(target);