Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
index 3cfa98e332537d006ae392041f53cec2fa0bc40b..3b5e2084eba16f34e19eb20500d81476f0e90f1d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
@@ -42,7 +42,7 @@ WebInspector.EventListenerBreakpointsSidebarPane = function()
this._createCategory(WebInspector.UIString("Window"), ["close"], true);
this._createCategory(WebInspector.UIString("XHR"), ["readystatechange", "load", "loadstart", "loadend", "abort", "error", "progress", "timeout"], false, ["XMLHttpRequest", "XMLHttpRequestUpload"]);
- WebInspector.targetManager.observeTargets(this, WebInspector.Target.Type.Page);
+ WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capability.Browser);
}
WebInspector.EventListenerBreakpointsSidebarPane.categoryListener = "listener:";
@@ -234,20 +234,20 @@ WebInspector.EventListenerBreakpointsSidebarPane.prototype = {
*/
_updateBreakpointOnTarget: function(eventName, eventTargetName, enable, target)
{
- var targets = target ? [target] : WebInspector.targetManager.targets(WebInspector.Target.Type.Page);
- for (var i = 0; i < targets.length; ++i) {
+ var targets = target ? [target] : WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser);
+ for (target of targets) {
if (eventName.startsWith(WebInspector.EventListenerBreakpointsSidebarPane.categoryListener)) {
var protocolEventName = eventName.substring(WebInspector.EventListenerBreakpointsSidebarPane.categoryListener.length);
if (enable)
- targets[i].domdebuggerAgent().setEventListenerBreakpoint(protocolEventName, eventTargetName);
+ target.domdebuggerAgent().setEventListenerBreakpoint(protocolEventName, eventTargetName);
else
- targets[i].domdebuggerAgent().removeEventListenerBreakpoint(protocolEventName, eventTargetName);
+ target.domdebuggerAgent().removeEventListenerBreakpoint(protocolEventName, eventTargetName);
} else if (eventName.startsWith(WebInspector.EventListenerBreakpointsSidebarPane.categoryInstrumentation)) {
var protocolEventName = eventName.substring(WebInspector.EventListenerBreakpointsSidebarPane.categoryInstrumentation.length);
if (enable)
- targets[i].domdebuggerAgent().setInstrumentationBreakpoint(protocolEventName);
+ target.domdebuggerAgent().setInstrumentationBreakpoint(protocolEventName);
else
- targets[i].domdebuggerAgent().removeInstrumentationBreakpoint(protocolEventName);
+ target.domdebuggerAgent().removeInstrumentationBreakpoint(protocolEventName);
}
}
},

Powered by Google App Engine
This is Rietveld 408576698