third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js ('k') | third_party/WebKit/Source/devtools/front_end/components/Spectrum.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js b/third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js

index 21f09f6ecda170b2f046af394af3ad1937e7f067..a128fe89b1ffcf7308afa03c3efe7740bf53b108 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js

@@ -20,7 +20,7 @@ WebInspector.RequestAppBannerActionDelegate.prototype = {

handleAction: function(context, actionId)

{

var target = WebInspector.targetManager.mainTarget();

- if (target && target.isPage()) {

+ if (target && target.hasBrowserCapability()) {

target.pageAgent().requestAppBanner();

WebInspector.console.show();

}