third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

index 8243eaed0b38cb110536c32a511f2a509e398b3d..26038c1606607fa42d318cfd9c013fc2b7638c0d 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

@@ -21,7 +21,7 @@ WebInspector.XHRBreakpointsSidebarPane = function()

this.emptyElement.addEventListener("contextmenu", this._emptyElementContextMenu.bind(this), true);

- WebInspector.targetManager.observeTargets(this, WebInspector.Target.Type.Page);

+ WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capability.Browser);

}

WebInspector.XHRBreakpointsSidebarPane.prototype = {

@@ -139,12 +139,12 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {

_updateBreakpointOnTarget: function(url, enable, target)

{

- var targets = target ? [target] : WebInspector.targetManager.targets(WebInspector.Target.Type.Page);

- for (var i = 0; i < targets.length; ++i) {

+ var targets = target ? [target] : WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser);

+ for (target of targets) {

if (enable)

- targets[i].domdebuggerAgent().setXHRBreakpoint(url);

+ target.domdebuggerAgent().setXHRBreakpoint(url);

else

- targets[i].domdebuggerAgent().removeXHRBreakpoint(url);

+ target.domdebuggerAgent().removeXHRBreakpoint(url);

}