Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
index 6db738a7cc093b0fba9436b158030d3b0871b9f8..507c470e0ac5ca11f4bb4617e8f9e08956d1738c 100644
--- a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
+++ b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
@@ -35,7 +35,7 @@ WebInspector.AnimationTimeline = function()
/** @type {!Map.<string, !WebInspector.AnimationModel.Animation>} */
this._animationsMap = new Map();
WebInspector.targetManager.addModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.NodeRemoved, this._nodeRemoved, this);
- WebInspector.targetManager.observeTargets(this, WebInspector.Target.Type.Page);
+ WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capability.Browser);
WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, this._nodeChanged, this);
}
@@ -51,13 +51,13 @@ WebInspector.AnimationTimeline._ControlState = {
WebInspector.AnimationTimeline.prototype = {
wasShown: function()
{
- for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page))
+ for (var target of WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser))
this._addEventListeners(target);
},
willHide: function()
{
- for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page))
+ for (var target of WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser))
this._removeEventListeners(target);
this._popoverHelper.hidePopover();
},

Powered by Google App Engine
This is Rietveld 408576698