third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js b/third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js

index 1942cbd80fcd152da0859284d4bcc68619f73f49..c703eacbd3ba549813163c4bd56a1b6338e52204 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js

@@ -18,7 +18,7 @@ WebInspector.TargetsComboBoxController = function(selectElement, elementToHide)

this._targetToOption = new Map();

WebInspector.context.addFlavorChangeListener(WebInspector.Target, this._targetChangedExternally, this);

- WebInspector.targetManager.observeTargets(this);

+ WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capability.JS);

}

WebInspector.TargetsComboBoxController.prototype = {

@@ -29,8 +29,6 @@ WebInspector.TargetsComboBoxController.prototype = {

targetAdded: function(target)

{

- if (!target.hasJSContext())

- return;

var option = this._selectElement.createChild("option");

option.text = target.name();

option.__target = target;

@@ -47,8 +45,6 @@ WebInspector.TargetsComboBoxController.prototype = {

targetRemoved: function(target)

{

- if (!target.hasJSContext())

- return;

var option = this._targetToOption.remove(target);

this._selectElement.removeChild(option);

this._updateVisibility();