third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js b/third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js

index 08ee5fa626fef308661d1b4c2d182bae2f621992..7ede716c22851dd4be9e6eb1e2811fc11ea2fd0b 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js

@@ -26,7 +26,7 @@ WebInspector.Geolocation.prototype = {

apply: function()

{

- for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page)) {

+ for (var target of WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser)) {

if (this.error)

target.emulationAgent().setGeolocationOverride();

else

@@ -36,7 +36,7 @@ WebInspector.Geolocation.prototype = {

clear: function()

{

- for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page))

+ for (var target of WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser))

target.emulationAgent().clearGeolocationOverride();

}