[builtins] Unify most of the remaining Math builtins.

[builtins] Unify most of the remaining Math builtins.

Import fdlibm versions of acos, acosh, asin and asinh, which are more
precise and produce the same result across platforms (we were using
libm versions for asin and acos so far, where both speed and precision
depended on the operating system so far). Introduce appropriate TurboFan
operators for these functions and use them both for inlining and for the
generic builtin.

Also migrate the Math.imul and Math.fround builtins to TurboFan builtins
to ensure that their behavior is always exactly the same as the inlined
TurboFan version (i.e. C++ truncation semantics for double to float
don't necessarily meet the JavaScript semantics).

For completeness, also migrate Math.sign, which can even get some nice
love in TurboFan.

Drive-by-fix: Some alpha-sorting on the Math related functions, and
cleanup the list of Math intrinsics that we have to export via the
native context currently.

BUG=v8:3266, v8:3496, v8:3509, v8:3952, v8:5169, v8:5170, v8:5171, v8:5172
TBR=rossberg@chromium.org
R=franzih@chromium.org

Committed: https://crrev.com/0a0fe8fb8b06d5e90b082838739ebf44cab04028
Cr-Commit-Position: refs/heads/master@{#37476}

[Benedikt Meurer, 2016-07-01 07:44:44]

Hey Franziska,

Here's the cleanup for the remaining Math stuff, except Math.random, which
requires some special love.
Please take a look.

Thanks,
Benedikt

[Franzi, 2016-07-01 09:09:48]

https://codereview.chromium.org/2116753002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2116753002/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:1700: SimpleInstallFunction(math, "pow", Builtins::kMathPow,
2, true);
Where are we using %math_pow? I didn't find it.

https://codereview.chromium.org/2116753002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/2116753002/diff/1/src/builtins.cc#newcode2705
src/builtins.cc:2705:
assembler->Return(assembler->ChangeFloat64ToTagged(x_value));
Can we return x instead of converting the float back to tagged?

https://codereview.chromium.org/2116753002/diff/1/src/compiler/js-builtin-red...
File src/compiler/js-builtin-reducer.cc (right):

https://codereview.chromium.org/2116753002/diff/1/src/compiler/js-builtin-red...
src/compiler/js-builtin-reducer.cc:152: }
This is a lot of code duplication. Can we use a macro? Or would readability
suffer too much?

[Franzi, 2016-07-01 10:43:10]

lgtm

[Benedikt Meurer, 2016-07-01 10:48:33]

https://codereview.chromium.org/2116753002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2116753002/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:1700: SimpleInstallFunction(math, "pow", Builtins::kMathPow,
2, true);
It's used to implement ** in the parser.

https://codereview.chromium.org/2116753002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/2116753002/diff/1/src/builtins.cc#newcode2705
src/builtins.cc:2705:
assembler->Return(assembler->ChangeFloat64ToTagged(x_value));
No we can't because x can be anything, not even a number.

https://codereview.chromium.org/2116753002/diff/1/src/compiler/js-builtin-red...
File src/compiler/js-builtin-reducer.cc (right):

https://codereview.chromium.org/2116753002/diff/1/src/compiler/js-builtin-red...
src/compiler/js-builtin-reducer.cc:152: }
Not a macro, but we will unify this whole file using methods some day. Some
startup project for the next noogler or intern maybe :-)

[Benedikt Meurer, 2016-07-01 10:48:40]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-07-01 10:48:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 10:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 10:53:22]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18641)

[Benedikt Meurer, 2016-07-01 11:09:13]

Description was changed from

==========
[builtins] Unify most of the remaining Math builtins.

Import fdlibm versions of acos, acosh, asin and asinh, which are more
precise and produce the same result across platforms (we were using
libm versions for asin and acos so far, where both speed and precision
depended on the operating system so far). Introduce appropriate TurboFan
operators for these functions and use them both for inlining and for the
generic builtin.

Also migrate the Math.imul and Math.fround builtins to TurboFan builtins
to ensure that their behavior is always exactly the same as the inlined
TurboFan version (i.e. C++ truncation semantics for double to float
don't necessarily meet the JavaScript semantics).

For completeness, also migrate Math.sign, which can even get some nice
love in TurboFan.

Drive-by-fix: Some alpha-sorting on the Math related functions, and
cleanup the list of Math intrinsics that we have to export via the
native context currently.

BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172
R=franzih@chromium.org
==========

to

==========
[builtins] Unify most of the remaining Math builtins.

Import fdlibm versions of acos, acosh, asin and asinh, which are more
precise and produce the same result across platforms (we were using
libm versions for asin and acos so far, where both speed and precision
depended on the operating system so far). Introduce appropriate TurboFan
operators for these functions and use them both for inlining and for the
generic builtin.

Also migrate the Math.imul and Math.fround builtins to TurboFan builtins
to ensure that their behavior is always exactly the same as the inlined
TurboFan version (i.e. C++ truncation semantics for double to float
don't necessarily meet the JavaScript semantics).

For completeness, also migrate Math.sign, which can even get some nice
love in TurboFan.

Drive-by-fix: Some alpha-sorting on the Math related functions, and
cleanup the list of Math intrinsics that we have to export via the
native context currently.

BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172
TBR=rossberg@chromium.org
R=franzih@chromium.org
==========

[Benedikt Meurer, 2016-07-01 11:09:23]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-07-01 11:09:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 11:11:47]

Description was changed from

==========
[builtins] Unify most of the remaining Math builtins.

Import fdlibm versions of acos, acosh, asin and asinh, which are more
precise and produce the same result across platforms (we were using
libm versions for asin and acos so far, where both speed and precision
depended on the operating system so far). Introduce appropriate TurboFan
operators for these functions and use them both for inlining and for the
generic builtin.

Also migrate the Math.imul and Math.fround builtins to TurboFan builtins
to ensure that their behavior is always exactly the same as the inlined
TurboFan version (i.e. C++ truncation semantics for double to float
don't necessarily meet the JavaScript semantics).

For completeness, also migrate Math.sign, which can even get some nice
love in TurboFan.

Drive-by-fix: Some alpha-sorting on the Math related functions, and
cleanup the list of Math intrinsics that we have to export via the
native context currently.

BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172
TBR=rossberg@chromium.org
R=franzih@chromium.org
==========

to

==========
[builtins] Unify most of the remaining Math builtins.

Import fdlibm versions of acos, acosh, asin and asinh, which are more
precise and produce the same result across platforms (we were using
libm versions for asin and acos so far, where both speed and precision
depended on the operating system so far). Introduce appropriate TurboFan
operators for these functions and use them both for inlining and for the
generic builtin.

Also migrate the Math.imul and Math.fround builtins to TurboFan builtins
to ensure that their behavior is always exactly the same as the inlined
TurboFan version (i.e. C++ truncation semantics for double to float
don't necessarily meet the JavaScript semantics).

For completeness, also migrate Math.sign, which can even get some nice
love in TurboFan.

Drive-by-fix: Some alpha-sorting on the Math related functions, and
cleanup the list of Math intrinsics that we have to export via the
native context currently.

BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172
TBR=rossberg@chromium.org
R=franzih@chromium.org
==========

[commit-bot: I haz the power, 2016-07-01 11:11:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-01 11:13:18]

Description was changed from

==========
[builtins] Unify most of the remaining Math builtins.

Import fdlibm versions of acos, acosh, asin and asinh, which are more
precise and produce the same result across platforms (we were using
libm versions for asin and acos so far, where both speed and precision
depended on the operating system so far). Introduce appropriate TurboFan
operators for these functions and use them both for inlining and for the
generic builtin.

Also migrate the Math.imul and Math.fround builtins to TurboFan builtins
to ensure that their behavior is always exactly the same as the inlined
TurboFan version (i.e. C++ truncation semantics for double to float
don't necessarily meet the JavaScript semantics).

For completeness, also migrate Math.sign, which can even get some nice
love in TurboFan.

Drive-by-fix: Some alpha-sorting on the Math related functions, and
cleanup the list of Math intrinsics that we have to export via the
native context currently.

BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172
TBR=rossberg@chromium.org
R=franzih@chromium.org
==========

to

==========
[builtins] Unify most of the remaining Math builtins.

Import fdlibm versions of acos, acosh, asin and asinh, which are more
precise and produce the same result across platforms (we were using
libm versions for asin and acos so far, where both speed and precision
depended on the operating system so far). Introduce appropriate TurboFan
operators for these functions and use them both for inlining and for the
generic builtin.

Also migrate the Math.imul and Math.fround builtins to TurboFan builtins
to ensure that their behavior is always exactly the same as the inlined
TurboFan version (i.e. C++ truncation semantics for double to float
don't necessarily meet the JavaScript semantics).

For completeness, also migrate Math.sign, which can even get some nice
love in TurboFan.

Drive-by-fix: Some alpha-sorting on the Math related functions, and
cleanup the list of Math intrinsics that we have to export via the
native context currently.

BUG=v8:3266,v8:3496,v8:3509,v8:3952,v8:5169,v8:5170,v8:5171,v8:5172
TBR=rossberg@chromium.org
R=franzih@chromium.org

Committed: https://crrev.com/0a0fe8fb8b06d5e90b082838739ebf44cab04028
Cr-Commit-Position: refs/heads/master@{#37476}
==========

[commit-bot: I haz the power, 2016-07-01 11:13:19]

Patchset 1 (id:??) landed as
https://crrev.com/0a0fe8fb8b06d5e90b082838739ebf44cab04028
Cr-Commit-Position: refs/heads/master@{#37476}