Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: test/cctest/test-serialize.cc

Issue 2116753002: [builtins] Unify most of the remaining Math builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2102223005
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index 9fc9e1c46a2c311ded7d67c37326904c6bf63048..2df0f0e799f4f63bbb40469116164f119901addf 100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -811,7 +811,7 @@ TEST(SnapshotDataBlobWithWarmup) {
// Running the warmup script has effect on whether functions are
// pre-compiled, but does not pollute the context.
CHECK(IsCompiled("Math.abs"));
- CHECK(!IsCompiled("Math.sign"));
+ CHECK(!IsCompiled("Number.isFinite"));
CHECK(CompileRun("Math.random")->IsFunction());
}
isolate->Dispose();
@@ -821,8 +821,8 @@ TEST(CustomSnapshotDataBlobWithWarmup) {
DisableTurbofan();
const char* source =
"function f() { return Math.abs(1); }\n"
- "function g() { return Math.sign(1); }\n"
- "Math.asinh(1);"
+ "function g() { return Number.isFinite(1); }\n"
+ "Number.isNaN(1);"
"var a = 5";
const char* warmup = "a = f()";
@@ -846,8 +846,8 @@ TEST(CustomSnapshotDataBlobWithWarmup) {
CHECK(IsCompiled("f"));
CHECK(IsCompiled("Math.abs"));
CHECK(!IsCompiled("g"));
- CHECK(!IsCompiled("Math.sign"));
- CHECK(!IsCompiled("Math.asinh"));
+ CHECK(!IsCompiled("Number.isFinite"));
+ CHECK(!IsCompiled("Number.isNaN"));
CHECK_EQ(5, CompileRun("a")->Int32Value(context).FromJust());
}
isolate->Dispose();

Powered by Google App Engine
This is Rietveld 408576698