src/js/v8natives.js - Issue 2116753002: [builtins] Unify most of the remaining Math builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/v8natives.js

Issue 2116753002: [builtins] Unify most of the remaining Math builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2102223005

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/v8natives.js

diff --git a/src/js/v8natives.js b/src/js/v8natives.js

index 9f0ac087f43522cc35e5aead9d47c86e6688f511..6db941bffe90f6166bd2943c80e04be55a4e1703 100644

--- a/src/js/v8natives.js

+++ b/src/js/v8natives.js

@@ -363,7 +363,7 @@ function NumberIsSafeInteger(number) {

if (NumberIsFinite(number)) {

var integral = TO_INTEGER(number);

if (integral == number) {

- return %math_abs(integral) <= kMaxSafeInteger;

+ return -kMaxSafeInteger <= integral && integral <= kMaxSafeInteger;

}

return false;