[builtins] Unify most of the remaining Math builtins.

src/compiler/js-builtin-reducer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-builtin-reducer.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/simplified-operator.h"
 #include "src/objects-inl.h"
@@ skipping 85 matching lines @@
   JSCallReduction r(node);
   if (r.InputsMatchOne(Type::PlainPrimitive())) {
     // Math.abs(a:plain-primitive) -> NumberAbs(ToNumber(a))
     Node* input = ToNumber(r.GetJSCallInput(0));
     Node* value = graph()->NewNode(simplified()->NumberAbs(), input);
     return Replace(value);
   }
   return NoChange();
 }
 
+// ES6 section 20.2.2.2 Math.acos ( x )
+Reduction JSBuiltinReducer::ReduceMathAcos(Node* node) {
+  JSCallReduction r(node);
+  if (r.InputsMatchOne(Type::PlainPrimitive())) {
+    // Math.acos(a:plain-primitive) -> NumberAcos(ToNumber(a))
+    Node* input = ToNumber(r.GetJSCallInput(0));
+    Node* value = graph()->NewNode(simplified()->NumberAcos(), input);
+    return Replace(value);
+  }
+  return NoChange();
+}
+
+// ES6 section 20.2.2.3 Math.acosh ( x )
+Reduction JSBuiltinReducer::ReduceMathAcosh(Node* node) {
+  JSCallReduction r(node);
+  if (r.InputsMatchOne(Type::PlainPrimitive())) {
+    // Math.acosh(a:plain-primitive) -> NumberAcosh(ToNumber(a))
+    Node* input = ToNumber(r.GetJSCallInput(0));
+    Node* value = graph()->NewNode(simplified()->NumberAcosh(), input);
+    return Replace(value);
+  }
+  return NoChange();
+}
+
+// ES6 section 20.2.2.4 Math.asin ( x )
+Reduction JSBuiltinReducer::ReduceMathAsin(Node* node) {
+  JSCallReduction r(node);
+  if (r.InputsMatchOne(Type::PlainPrimitive())) {
+    // Math.asin(a:plain-primitive) -> NumberAsin(ToNumber(a))
+    Node* input = ToNumber(r.GetJSCallInput(0));
+    Node* value = graph()->NewNode(simplified()->NumberAsin(), input);
+    return Replace(value);
+  }
+  return NoChange();
+}
+
+// ES6 section 20.2.2.5 Math.asinh ( x )
+Reduction JSBuiltinReducer::ReduceMathAsinh(Node* node) {
+  JSCallReduction r(node);
+  if (r.InputsMatchOne(Type::PlainPrimitive())) {
+    // Math.asinh(a:plain-primitive) -> NumberAsinh(ToNumber(a))
+    Node* input = ToNumber(r.GetJSCallInput(0));
+    Node* value = graph()->NewNode(simplified()->NumberAsinh(), input);
+    return Replace(value);
+  }
+  return NoChange();
+}

[Franzi, 2016/07/01 09:09:48]

This is a lot of code duplication. Can we use a macro? Or would readability
suffer too much?

[Benedikt Meurer, 2016/07/01 10:48:33]

Not a macro, but we will unify this whole file using methods some day. Some
startup project for the next noogler or intern maybe :-)

+
 // ES6 section 20.2.2.6 Math.atan ( x )
 Reduction JSBuiltinReducer::ReduceMathAtan(Node* node) {
   JSCallReduction r(node);
   if (r.InputsMatchOne(Type::PlainPrimitive())) {
     // Math.atan(a:plain-primitive) -> NumberAtan(ToNumber(a))
     Node* input = ToNumber(r.GetJSCallInput(0));
     Node* value = graph()->NewNode(simplified()->NumberAtan(), input);
     return Replace(value);
   }
   return NoChange();
 }
 
+// ES6 section 20.2.2.7 Math.atanh ( x )
+Reduction JSBuiltinReducer::ReduceMathAtanh(Node* node) {
+  JSCallReduction r(node);
+  if (r.InputsMatchOne(Type::PlainPrimitive())) {
+    // Math.atanh(a:plain-primitive) -> NumberAtanh(ToNumber(a))
+    Node* input = ToNumber(r.GetJSCallInput(0));
+    Node* value = graph()->NewNode(simplified()->NumberAtanh(), input);
+    return Replace(value);
+  }
+  return NoChange();
+}
+
 // ES6 section 20.2.2.8 Math.atan2 ( y, x )
 Reduction JSBuiltinReducer::ReduceMathAtan2(Node* node) {
   JSCallReduction r(node);
   if (r.InputsMatchTwo(Type::PlainPrimitive(), Type::PlainPrimitive())) {
     // Math.atan2(a:plain-primitive,
     //            b:plain-primitive) -> NumberAtan2(ToNumber(a),
     //                                              ToNumber(b))
     Node* left = ToNumber(r.left());
     Node* right = ToNumber(r.right());
     Node* value = graph()->NewNode(simplified()->NumberAtan2(), left, right);
     return Replace(value);
   }
   return NoChange();
 }
 
-// ES6 section 20.2.2.7 Math.atanh ( x )
-Reduction JSBuiltinReducer::ReduceMathAtanh(Node* node) {
-  JSCallReduction r(node);
-  if (r.InputsMatchOne(Type::Number())) {
-    // Math.atanh(a:number) -> NumberAtanh(a)
-    Node* value = graph()->NewNode(simplified()->NumberAtanh(), r.left());
-    return Replace(value);
-  }
-  return NoChange();
-}
-
 // ES6 section 20.2.2.10 Math.ceil ( x )
 Reduction JSBuiltinReducer::ReduceMathCeil(Node* node) {
   JSCallReduction r(node);
   if (r.InputsMatchOne(Type::PlainPrimitive())) {
     // Math.ceil(a:plain-primitive) -> NumberCeil(ToNumber(a))
     Node* input = ToNumber(r.GetJSCallInput(0));
     Node* value = graph()->NewNode(simplified()->NumberCeil(), input);
     return Replace(value);
   }
   return NoChange();
@@ skipping 227 matching lines @@
 Reduction JSBuiltinReducer::ReduceMathCbrt(Node* node) {
   JSCallReduction r(node);
   if (r.InputsMatchOne(Type::Number())) {
     // Math.cbrt(a:number) -> NumberCbrt(a)
     Node* value = graph()->NewNode(simplified()->NumberCbrt(), r.left());
     return Replace(value);
   }
   return NoChange();
 }
 
+// ES6 section 20.2.2.29 Math.sign ( x )
+Reduction JSBuiltinReducer::ReduceMathSign(Node* node) {
+  JSCallReduction r(node);
+  if (r.InputsMatchOne(Type::PlainPrimitive())) {
+    // Math.sign(a:plain-primitive) -> NumberSign(ToNumber(a))
+    Node* input = ToNumber(r.GetJSCallInput(0));
+    Node* value = graph()->NewNode(simplified()->NumberSign(), input);
+    return Replace(value);
+  }
+  return NoChange();
+}
+
 // ES6 section 20.2.2.30 Math.sin ( x )
 Reduction JSBuiltinReducer::ReduceMathSin(Node* node) {
   JSCallReduction r(node);
   if (r.InputsMatchOne(Type::PlainPrimitive())) {
     // Math.sin(a:plain-primitive) -> NumberSin(ToNumber(a))
     Node* input = ToNumber(r.GetJSCallInput(0));
     Node* value = graph()->NewNode(simplified()->NumberSin(), input);
     return Replace(value);
   }
   return NoChange();
@@ skipping 74 matching lines @@
 Reduction JSBuiltinReducer::Reduce(Node* node) {
   Reduction reduction = NoChange();
   JSCallReduction r(node);
 
   // Dispatch according to the BuiltinFunctionId if present.
   if (!r.HasBuiltinFunctionId()) return NoChange();
   switch (r.GetBuiltinFunctionId()) {
     case kMathAbs:
       reduction = ReduceMathAbs(node);
       break;
+    case kMathAcos:
+      reduction = ReduceMathAcos(node);
+      break;
+    case kMathAcosh:
+      reduction = ReduceMathAcosh(node);
+      break;
+    case kMathAsin:
+      reduction = ReduceMathAsin(node);
+      break;
+    case kMathAsinh:
+      reduction = ReduceMathAsinh(node);
+      break;
     case kMathAtan:
       reduction = ReduceMathAtan(node);
       break;
+    case kMathAtanh:
+      reduction = ReduceMathAtanh(node);
+      break;
     case kMathAtan2:
       reduction = ReduceMathAtan2(node);
       break;
-    case kMathAtanh:
-      reduction = ReduceMathAtanh(node);
-      break;
     case kMathCbrt:
       reduction = ReduceMathCbrt(node);
       break;
     case kMathCeil:
       reduction = ReduceMathCeil(node);
       break;
     case kMathClz32:
       reduction = ReduceMathClz32(node);
       break;
     case kMathCos:
@@ skipping 34 matching lines @@
       break;
     case kMathMin:
       reduction = ReduceMathMin(node);
       break;
     case kMathPow:
       reduction = ReduceMathPow(node);
       break;
     case kMathRound:
       reduction = ReduceMathRound(node);
       break;
+    case kMathSign:
+      reduction = ReduceMathSign(node);
+      break;
     case kMathSin:
       reduction = ReduceMathSin(node);
       break;
     case kMathSinh:
       reduction = ReduceMathSinh(node);
       break;
     case kMathSqrt:
       reduction = ReduceMathSqrt(node);
       break;
     case kMathTan:
@@ skipping 43 matching lines @@
 }
 
 
 SimplifiedOperatorBuilder* JSBuiltinReducer::simplified() const {
   return jsgraph()->simplified();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8