Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: src/assembler.cc

Issue 2116753002: [builtins] Unify most of the remaining Math builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2102223005
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.h ('k') | src/base/ieee754.h » ('j') | src/bootstrapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index 2ac086d371c6cfb70fc89f77ebd78e1ff78a4802..cec9298cac3e5cdb1174c439ce4c5f7dbedd415c 100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -1142,7 +1142,7 @@ ExternalReference ExternalReference::wasm_word64_popcnt(Isolate* isolate) {
}
static void f64_acos_wrapper(double* param) {
- WriteDoubleValue(param, std::acos(ReadDoubleValue(param)));
+ WriteDoubleValue(param, base::ieee754::acos(ReadDoubleValue(param)));
}
ExternalReference ExternalReference::f64_acos_wrapper_function(
@@ -1151,7 +1151,7 @@ ExternalReference ExternalReference::f64_acos_wrapper_function(
}
static void f64_asin_wrapper(double* param) {
- WriteDoubleValue(param, std::asin(ReadDoubleValue(param)));
+ WriteDoubleValue(param, base::ieee754::asin(ReadDoubleValue(param)));
}
ExternalReference ExternalReference::f64_asin_wrapper_function(
@@ -1406,14 +1406,29 @@ ExternalReference ExternalReference::address_of_regexp_stack_memory_size(
#endif // V8_INTERPRETED_REGEXP
-ExternalReference ExternalReference::ieee754_atan_function(Isolate* isolate) {
+ExternalReference ExternalReference::ieee754_acos_function(Isolate* isolate) {
return ExternalReference(
- Redirect(isolate, FUNCTION_ADDR(base::ieee754::atan), BUILTIN_FP_CALL));
+ Redirect(isolate, FUNCTION_ADDR(base::ieee754::acos), BUILTIN_FP_CALL));
}
-ExternalReference ExternalReference::ieee754_atan2_function(Isolate* isolate) {
+ExternalReference ExternalReference::ieee754_acosh_function(Isolate* isolate) {
return ExternalReference(Redirect(
- isolate, FUNCTION_ADDR(base::ieee754::atan2), BUILTIN_FP_FP_CALL));
+ isolate, FUNCTION_ADDR(base::ieee754::acosh), BUILTIN_FP_FP_CALL));
+}
+
+ExternalReference ExternalReference::ieee754_asin_function(Isolate* isolate) {
+ return ExternalReference(
+ Redirect(isolate, FUNCTION_ADDR(base::ieee754::asin), BUILTIN_FP_CALL));
+}
+
+ExternalReference ExternalReference::ieee754_asinh_function(Isolate* isolate) {
+ return ExternalReference(Redirect(
+ isolate, FUNCTION_ADDR(base::ieee754::asinh), BUILTIN_FP_FP_CALL));
+}
+
+ExternalReference ExternalReference::ieee754_atan_function(Isolate* isolate) {
+ return ExternalReference(
+ Redirect(isolate, FUNCTION_ADDR(base::ieee754::atan), BUILTIN_FP_CALL));
}
ExternalReference ExternalReference::ieee754_atanh_function(Isolate* isolate) {
@@ -1421,6 +1436,11 @@ ExternalReference ExternalReference::ieee754_atanh_function(Isolate* isolate) {
isolate, FUNCTION_ADDR(base::ieee754::atanh), BUILTIN_FP_FP_CALL));
}
+ExternalReference ExternalReference::ieee754_atan2_function(Isolate* isolate) {
+ return ExternalReference(Redirect(
+ isolate, FUNCTION_ADDR(base::ieee754::atan2), BUILTIN_FP_FP_CALL));
+}
+
ExternalReference ExternalReference::ieee754_cbrt_function(Isolate* isolate) {
return ExternalReference(Redirect(isolate, FUNCTION_ADDR(base::ieee754::cbrt),
BUILTIN_FP_FP_CALL));
« no previous file with comments | « src/assembler.h ('k') | src/base/ieee754.h » ('j') | src/bootstrapper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698