[DevTools] Report unhandled exceptions and promise rejections through Runtime.

[DevTools] Report unhandled exceptions and promise rejections through Runtime.

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions can be evicted before Runtime.enable was called due to excessive number of console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG=613882
Committed: https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e
Cr-Commit-Position: refs/heads/master@{#404576}

[dgozman, 2016-07-06 22:02:08]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 22:03:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-07-06 22:05:54]

Description was changed from

==========
[DevTools] Report unhandled exceptions and promise rejections through Runtime.

BUG=613882
==========

to

==========
[DevTools] Report unhandled exceptions and promise rejections through Runtime.

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which
report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions
can be evicted before Runtime.enable was called due to excessive number of
console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG=613882
==========

[dgozman, 2016-07-06 22:09:40]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, pfeldman@chromium.org

[dgozman, 2016-07-06 22:09:41]

Could you please take a look?

[commit-bot: I haz the power, 2016-07-06 22:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 22:53:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pfeldman, 2016-07-07 01:12:17]

lgtm

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:2895: void
Document::logExceptionToConsole(const String& errorMessage,
std::unique_ptr<SourceLocation> location)
exeptionThrown

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:311: "name":
"exceptionUnhandled",
exceptionThrown

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:326: { "name":
"timestamp", "type": "number", "description": "Number of seconds since epoch.
TODO(dgozman): unify with Console.Timestamp" },
Can we use this as an opportunity to migrate to ms?

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:328: { "name":
"revokedExceptionId", "type": "integer", "description": "The id of revoked
exception, as reported in <code>exceptionUnhandled</code>." }
exceptionId

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:780: { "name":
"messageId", "type": "integer", "hidden": true, "optional": true, "description":
"Message id." },
These are no longer needed.

[kozy, 2016-07-08 18:49:00]

lgtm % nits

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:41:
MainThreadDebugger::instance()->exceptionUnhandled(frame(), errorMessage,
std::move(location));
Is threadDebugger always presented for WorkletGlobalScope?

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:387: [],
[] -> undefined?

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
(right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:301:
details->setLine(static_cast<int>(m_lineNumber));
Exception details line and columns will be zero-based:
https://codereview.chromium.org/2130203002/

[dgozman, 2016-07-08 18:56:41]

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:2895: void
Document::logExceptionToConsole(const String& errorMessage,
std::unique_ptr<SourceLocation> location)
On 2016/07/07 01:12:17, pfeldman wrote:
> exeptionThrown

Done.

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:41:
MainThreadDebugger::instance()->exceptionUnhandled(frame(), errorMessage,
std::move(location));
On 2016/07/08 18:48:59, kozyatinskiy wrote:
> Is threadDebugger always presented for WorkletGlobalScope?

Yes, it's a main thread isolate.

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:387: [],
On 2016/07/08 18:48:59, kozyatinskiy wrote:
> [] -> undefined?

Done.

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
(right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp:301:
details->setLine(static_cast<int>(m_lineNumber));
On 2016/07/08 18:48:59, kozyatinskiy wrote:
> Exception details line and columns will be zero-based:
> https://codereview.chromium.org/2130203002/

That's good! We'll unify them.

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:311: "name":
"exceptionUnhandled",
On 2016/07/07 01:12:17, pfeldman wrote:
> exceptionThrown

Done.

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:326: { "name":
"timestamp", "type": "number", "description": "Number of seconds since epoch.
TODO(dgozman): unify with Console.Timestamp" },
On 2016/07/07 01:12:17, pfeldman wrote:
> Can we use this as an opportunity to migrate to ms?

Done.

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:328: { "name":
"revokedExceptionId", "type": "integer", "description": "The id of revoked
exception, as reported in <code>exceptionUnhandled</code>." }
On 2016/07/07 01:12:17, pfeldman wrote:
> exceptionId

Done.

https://codereview.chromium.org/2116563003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:780: { "name":
"messageId", "type": "integer", "hidden": true, "optional": true, "description":
"Message id." },
On 2016/07/07 01:12:17, pfeldman wrote:
> These are no longer needed.

Done.

[dgozman, 2016-07-08 18:56:49]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 18:58:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 20:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 20:04:43]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-07-09 01:59:11]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-09 01:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2116563003/#ps40001
(title: "fixed comments, rebased, fixed 2 tests")

[commit-bot: I haz the power, 2016-07-09 01:59:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 04:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 04:00:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[dgozman, 2016-07-09 04:35:25]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-07-09 04:35:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 06:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 06:36:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[dgozman, 2016-07-09 13:59:32]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-07-09 13:59:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 16:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 16:00:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[dgozman, 2016-07-09 23:01:41]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-07-09 23:01:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2116563003/#ps60001
(title: "rebase after ExceptionDetails change")

[commit-bot: I haz the power, 2016-07-09 23:01:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-10 00:33:08]

Description was changed from

==========
[DevTools] Report unhandled exceptions and promise rejections through Runtime.

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which
report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions
can be evicted before Runtime.enable was called due to excessive number of
console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG=613882
==========

to

==========
[DevTools] Report unhandled exceptions and promise rejections through Runtime.

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which
report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions
can be evicted before Runtime.enable was called due to excessive number of
console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG=613882
==========

[commit-bot: I haz the power, 2016-07-10 00:33:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-10 00:35:03]

Description was changed from

==========
[DevTools] Report unhandled exceptions and promise rejections through Runtime.

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which
report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions
can be evicted before Runtime.enable was called due to excessive number of
console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG=613882
==========

to

==========
[DevTools] Report unhandled exceptions and promise rejections through Runtime.

Introduced Runtime.exceptionUnhandled and Runtime.exceptionRevoked methods which
report exceptions when Runtime is enabled.

Internally, we share the storage with console messages. That means exceptions
can be evicted before Runtime.enable was called due to excessive number of
console messages.

Rough edges:
- console.clear also clears the storage for exceptions;
- releaseObjectGroup("console") releases exception objects as well;
- integration on the frontend reuses ConsoleMessage and is somewhat ugly;
- we may want to separate console vs exceptions on backend side.

BUG=613882

Committed: https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e
Cr-Commit-Position: refs/heads/master@{#404576}
==========

[commit-bot: I haz the power, 2016-07-10 00:35:06]

Patchset 4 (id:??) landed as
https://crrev.com/c19cc78b55454d4d14c1e8888d3972accb879c6e
Cr-Commit-Position: refs/heads/master@{#404576}