Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase after ExceptionDetails change Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
index 523ecabc9892f6b1b5cf7202654febe467cb5714..44f865d7ba0cfdb1e0b04e8e2798e148cecb03fb 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
@@ -40,7 +40,7 @@ WebInspector.ConsoleModel = function(target)
/** @type {!Array.<!WebInspector.ConsoleMessage>} */
this._messages = [];
/** @type {!Map<number, !WebInspector.ConsoleMessage>} */
- this._messageById = new Map();
+ this._messageByExceptionId = new Map();
this._warnings = 0;
this._errors = 0;
this._revokedErrors = 0;
@@ -79,20 +79,20 @@ WebInspector.ConsoleModel.prototype = {
if (this._isBlacklisted(msg))
return;
- if (msg.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError && msg._relatedMessageId) {
- var relatedMessage = this._messageById.get(msg._relatedMessageId);
- if (!relatedMessage)
+ if (msg.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError && msg._revokedExceptionId) {
+ var exceptionMessage = this._messageByExceptionId.get(msg._revokedExceptionId);
+ if (!exceptionMessage)
return;
this._errors--;
this._revokedErrors++;
- relatedMessage.level = WebInspector.ConsoleMessage.MessageLevel.RevokedError;
- this.dispatchEventToListeners(WebInspector.ConsoleModel.Events.MessageUpdated, relatedMessage);
+ exceptionMessage.level = WebInspector.ConsoleMessage.MessageLevel.RevokedError;
+ this.dispatchEventToListeners(WebInspector.ConsoleModel.Events.MessageUpdated, exceptionMessage);
return;
}
this._messages.push(msg);
- if (msg._messageId)
- this._messageById.set(msg._messageId, msg);
+ if (msg._exceptionId)
+ this._messageByExceptionId.set(msg._exceptionId, msg);
this._incrementErrorWarningCount(msg);
this.dispatchEventToListeners(WebInspector.ConsoleModel.Events.MessageAdded, msg);
},
@@ -148,7 +148,7 @@ WebInspector.ConsoleModel.prototype = {
_messagesCleared: function()
{
this._messages = [];
- this._messageById.clear();
+ this._messageByExceptionId.clear();
this._errors = 0;
this._revokedErrors = 0;
this._warnings = 0;
@@ -244,10 +244,8 @@ WebInspector.ConsoleModel.clearConsole = function()
* @param {number=} timestamp
* @param {!RuntimeAgent.ExecutionContextId=} executionContextId
* @param {?string=} scriptId
- * @param {number=} messageId
- * @param {number=} relatedMessageId
*/
-WebInspector.ConsoleMessage = function(target, source, level, messageText, type, url, line, column, requestId, parameters, stackTrace, timestamp, executionContextId, scriptId, messageId, relatedMessageId)
+WebInspector.ConsoleMessage = function(target, source, level, messageText, type, url, line, column, requestId, parameters, stackTrace, timestamp, executionContextId, scriptId)
{
this._target = target;
this.source = source;
@@ -266,8 +264,6 @@ WebInspector.ConsoleMessage = function(target, source, level, messageText, type,
this.timestamp = timestamp || Date.now();
this.executionContextId = executionContextId || 0;
this.scriptId = scriptId || null;
- this._messageId = messageId || 0;
- this._relatedMessageId = relatedMessageId || 0;
var networkLog = target && WebInspector.NetworkLog.fromTarget(target);
this.request = (requestId && networkLog) ? networkLog.requestForId(requestId) : null;
@@ -311,6 +307,22 @@ WebInspector.ConsoleMessage.prototype = {
},
/**
+ * @param {number} exceptionId
+ */
+ setExceptionId: function(exceptionId)
+ {
+ this._exceptionId = exceptionId;
+ },
+
+ /**
+ * @param {number} revokedExceptionId
+ */
+ setRevokedExceptionId: function(revokedExceptionId)
+ {
+ this._revokedExceptionId = revokedExceptionId;
+ },
+
+ /**
* @return {?WebInspector.ConsoleMessage}
*/
originatingMessage: function()
@@ -354,9 +366,9 @@ WebInspector.ConsoleMessage.prototype = {
if (!msg)
return false;
- if (this._messageId || msg._messageId)
+ if (this._exceptionId || msg._exceptionId)
return false;
- if (this._relatedMessageId || msg._relatedMessageId)
+ if (this._revokedExceptionId || msg._revokedExceptionId)
return false;
if (!this._isEqualStackTraces(this.stackTrace, msg.stackTrace))
@@ -458,7 +470,7 @@ WebInspector.ConsoleMessage.MessageLevel = {
Warning: "warning",
Error: "error",
Debug: "debug",
- RevokedError: "revokedError"
+ RevokedError: "revokedError" // This is frontend-only level, used to put exceptions to console.
};
/**
@@ -502,9 +514,7 @@ WebInspector.ConsoleDispatcher.prototype = {
payload.stack,
payload.timestamp * 1000, // Convert to ms.
payload.executionContextId,
- payload.scriptId,
- payload.messageId,
- payload.relatedMessageId);
+ payload.scriptId);
this._console.addMessage(consoleMessage);
},

Powered by Google App Engine
This is Rietveld 408576698