Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase after ExceptionDetails change Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
index 310e57d5268fe23f77e9ada5bd638b551d6332cd..55eff2c4b955b0fb908f3e6ba3fb6b2298489611 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
@@ -95,13 +95,16 @@ void V8ConsoleAgentImpl::reportAllMessages()
m_frontend.messageAdded(std::move(expired));
m_frontend.flush();
}
- for (const auto& message : storage->messages())
- reportMessage(message.get(), false);
+ for (const auto& message : storage->messages()) {
+ if (message->origin() == V8MessageOrigin::kConsole)
+ reportMessage(message.get(), false);
+ }
}
void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generatePreview)
{
- m_frontend.messageAdded(message->buildInspectorObject(m_session, generatePreview));
+ DCHECK_EQ(V8MessageOrigin::kConsole, message->origin());
+ message->reportToFrontend(&m_frontend, m_session, generatePreview);
m_frontend.flush();
}

Powered by Google App Engine
This is Rietveld 408576698