Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2845)

Unified Diff: chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase after ExceptionDetails change Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/console/exception-from-worker-contains-stack.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
diff --git a/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js b/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
index cc68ec1b29d709f1a13f78748bb702f70a8fc52e..7fd7faef628fbe62a327d338c7eae7f92a19c746 100644
--- a/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
+++ b/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
@@ -5,8 +5,8 @@
function createTestFunction(expected_message) {
return function(tab) {
function onDebuggerEvent(debuggee, method, params) {
- if (debuggee.tabId == tab.id && method == 'Console.messageAdded') {
- if (params.message.text.indexOf(expected_message) > -1) {
+ if (debuggee.tabId == tab.id && method == 'Runtime.exceptionThrown') {
+ if (params.details.text.indexOf(expected_message) > -1) {
chrome.debugger.onEvent.removeListener(onDebuggerEvent);
chrome.test.succeed();
}
@@ -16,7 +16,7 @@ function createTestFunction(expected_message) {
chrome.debugger.attach({ tabId: tab.id }, "1.1", function() {
// Enabling console provides both stored and new messages via the
// Console.messageAdded event.
- chrome.debugger.sendCommand({ tabId: tab.id }, "Console.enable");
+ chrome.debugger.sendCommand({ tabId: tab.id }, "Runtime.enable");
});
}
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/console/exception-from-worker-contains-stack.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698