third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after ExceptionDetails change Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

index 50780b6f6c7b413d0f4f9e391066ce35b720a957..f0c7f3723298033e04e996ffed3efa4d1e78d296 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

@@ -42,6 +42,7 @@

#include "core/fetch/ResourceLoaderOptions.h"

#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/WorkerInspectorController.h"

+#include "core/inspector/WorkerThreadDebugger.h"

#include "core/loader/ThreadableLoader.h"

#include "core/origin_trials/OriginTrialContext.h"

#include "core/workers/WorkerClients.h"

@@ -212,11 +213,11 @@ CachedMetadataHandler* ServiceWorkerGlobalScope::createWorkerScriptCachedMetadat

return ServiceWorkerScriptCachedMetadataHandler::create(this, scriptURL, metaData);

}

-void ServiceWorkerGlobalScope::logExceptionToConsole(const String& errorMessage, std::unique_ptr<SourceLocation> location)

+void ServiceWorkerGlobalScope::exceptionThrown(const String& errorMessage, std::unique_ptr<SourceLocation> location)

{

- WorkerGlobalScope::logExceptionToConsole(errorMessage, location->clone());

- ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorMessage, std::move(location));

- addMessageToWorkerConsole(consoleMessage);

+ WorkerGlobalScope::exceptionThrown(errorMessage, location->clone());

+ if (WorkerThreadDebugger* debugger = WorkerThreadDebugger::from(thread()->isolate()))

+ debugger->exceptionThrown(errorMessage, std::move(location));

}

void ServiceWorkerGlobalScope::scriptLoaded(size_t scriptSize, size_t cachedMetadataSize)