third_party/WebKit/Source/core/testing/NullExecutionContext.h - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/NullExecutionContext.h

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after ExceptionDetails change Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp ('k') | third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/NullExecutionContext.h

diff --git a/third_party/WebKit/Source/core/testing/NullExecutionContext.h b/third_party/WebKit/Source/core/testing/NullExecutionContext.h

index fb0978971363b632be698a4a3a0cb4421d99d933..379de81959eaba6205ee6b9291b942e99e861563 100644

--- a/third_party/WebKit/Source/core/testing/NullExecutionContext.h

+++ b/third_party/WebKit/Source/core/testing/NullExecutionContext.h

@@ -38,7 +38,7 @@ public:

DOMTimerCoordinator* timers() override { return nullptr; }

void addConsoleMessage(ConsoleMessage*) override { }

- void logExceptionToConsole(const String& errorMessage, std::unique_ptr<SourceLocation>) override { }

+ void exceptionThrown(const String& errorMessage, std::unique_ptr<SourceLocation>) override { }

void setIsSecureContext(bool);

bool isSecureContext(String& errorMessage, const SecureContextCheck = StandardSecureContextCheck) const override;