third_party/WebKit/Source/core/dom/ExecutionContext.cpp - Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.cpp

Issue 2116563003: [DevTools] Report unhandled exceptions and promise rejections through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after ExceptionDetails change Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ExecutionContext.h ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ExecutionContext.cpp

diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

index 4251bcfb313dc117e60fa29e757f1e7e3ce0a0b4..c2e51cd3850d6d4a8f7cc2d6af4544b567fa6174 100644

--- a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

@@ -153,14 +153,14 @@ void ExecutionContext::reportException(ErrorEvent* errorEvent, AccessControlStat

// First report the original exception and only then all the nested ones.

if (!dispatchErrorEvent(errorEvent, corsStatus))

- logExceptionToConsole(errorEvent->messageForConsole(), errorEvent->location()->clone());

+ exceptionThrown(errorEvent->messageForConsole(), errorEvent->location()->clone());

if (!m_pendingExceptions)

return;

for (size_t i = 0; i < m_pendingExceptions->size(); i++) {

PendingException* e = m_pendingExceptions->at(i).get();

- logExceptionToConsole(e->m_errorMessage, std::move(e->m_location));

+ exceptionThrown(e->m_errorMessage, std::move(e->m_location));

}

m_pendingExceptions.reset();

}