Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit. (Closed)

Created:
4 years, 5 months ago by stgao
Modified:
4 years, 5 months ago
Reviewers:
chanli
CC:
chromium-reviews, infra-reviews+infra_chromium.org, lijeffrey, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Fix redirect bug and update template for waterfall/culprit. BUG=621140 Committed: https://chromium.googlesource.com/infra/infra/+/fc3db4e2ac868108a495ec67e9f81a94a7b5e81f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use build end time to check whether too late to send notification. #

Total comments: 4

Patch Set 3 : Fix wordings in email message. #

Patch Set 4 : Add one unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -39 lines) Patch
M appengine/findit/common/http_client_appengine.py View 2 chunks +6 lines, -2 lines 0 comments Download
M appengine/findit/common/rietveld.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/handlers/culprit.py View 1 chunk +2 lines, -0 lines 0 comments Download
M appengine/findit/handlers/test/culprit_test.py View 3 chunks +3 lines, -1 line 0 comments Download
M appengine/findit/main.py View 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/findit/model/test/wf_culprit_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/findit/model/wf_culprit.py View 2 chunks +5 lines, -1 line 0 comments Download
M appengine/findit/templates/waterfall/culprit.html View 1 4 chunks +5 lines, -5 lines 0 comments Download
M appengine/findit/waterfall/build_info.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/build_util.py View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/buildbot.py View 1 2 chunks +8 lines, -1 line 0 comments Download
M appengine/findit/waterfall/send_notification_for_culprit_pipeline.py View 1 2 4 chunks +21 lines, -15 lines 0 comments Download
M appengine/findit/waterfall/test/build_util_test.py View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/send_notification_for_culprit_pipeline_test.py View 1 9 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
stgao
mind a look at this small CL?
4 years, 5 months ago (2016-07-01 19:58:52 UTC) #2
chanli
lgtm with a nit https://codereview.chromium.org/2116073002/diff/1/appengine/findit/templates/waterfall/culprit.html File appengine/findit/templates/waterfall/culprit.html (right): https://codereview.chromium.org/2116073002/diff/1/appengine/findit/templates/waterfall/culprit.html#newcode41 appengine/findit/templates/waterfall/culprit.html:41: Analysis nit: Since the header ...
4 years, 5 months ago (2016-07-01 20:17:36 UTC) #3
stgao
https://codereview.chromium.org/2116073002/diff/1/appengine/findit/templates/waterfall/culprit.html File appengine/findit/templates/waterfall/culprit.html (right): https://codereview.chromium.org/2116073002/diff/1/appengine/findit/templates/waterfall/culprit.html#newcode41 appengine/findit/templates/waterfall/culprit.html:41: Analysis On 2016/07/01 20:17:36, chanli wrote: > nit: Since ...
4 years, 5 months ago (2016-07-01 22:47:30 UTC) #4
chanli
lgtm with nits on the message. https://codereview.chromium.org/2116073002/diff/20001/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py File appengine/findit/waterfall/send_notification_for_culprit_pipeline.py (right): https://codereview.chromium.org/2116073002/diff/20001/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py#newcode65 appengine/findit/waterfall/send_notification_for_culprit_pipeline.py:65: FYI: Findit try-jobs ...
4 years, 5 months ago (2016-07-01 23:14:59 UTC) #5
stgao
https://codereview.chromium.org/2116073002/diff/20001/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py File appengine/findit/waterfall/send_notification_for_culprit_pipeline.py (right): https://codereview.chromium.org/2116073002/diff/20001/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py#newcode65 appengine/findit/waterfall/send_notification_for_culprit_pipeline.py:65: FYI: Findit try-jobs (rerunning failed compile or tests) identified ...
4 years, 5 months ago (2016-07-06 16:12:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116073002/40001
4 years, 5 months ago (2016-07-06 16:12:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Precise 32 Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Precise%2032%20Tester/builds/2899)
4 years, 5 months ago (2016-07-06 16:26:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2116073002/60001
4 years, 5 months ago (2016-07-06 17:49:26 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:04:04 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/fc3db4e2ac868108a495ec67e9f81...

Powered by Google App Engine
This is Rietveld 408576698