Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: appengine/findit/waterfall/test/build_util_test.py

Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add one unittest. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/build_util_test.py
diff --git a/appengine/findit/waterfall/test/build_util_test.py b/appengine/findit/waterfall/test/build_util_test.py
index 99dd4541a12dd625bb71946794fa048705bb4383..5e44c854eebfd6a4020e211712d5ddac689d9988 100644
--- a/appengine/findit/waterfall/test/build_util_test.py
+++ b/appengine/findit/waterfall/test/build_util_test.py
@@ -166,3 +166,22 @@ class BuildUtilTest(wf_testcase.WaterfallTestCase):
self.assertEqual(build.data_source, build_util.BUILDBOT_MASTER)
self.assertEqual(build.data, 'Test get build data from build master')
+
+ def testGetBuildEndTime(self):
+ cases = {
+ 'null': None,
+ '1467740016': datetime.datetime(2016, 7, 5, 17, 33, 36),
+ }
+ for end_time, expected_time in cases.iteritems():
+ master_name = 'm'
+ builder_name = 'b'
+ build_number = 123
+ build = WfBuild.Create(master_name, builder_name, build_number)
+ build.data = '{"times": [1467738821, %s]}' % end_time
+ build.completed = True
+ build.last_crawled_time = self._TimeBeforeNowBySeconds(10)
+ build.put()
+
+ self.assertEqual(expected_time,
+ build_util.GetBuildEndTime(
+ master_name, builder_name, build_number))

Powered by Google App Engine
This is Rietveld 408576698