Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5771)

Unified Diff: appengine/findit/handlers/culprit.py

Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add one unittest. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/common/rietveld.py ('k') | appengine/findit/handlers/test/culprit_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/culprit.py
diff --git a/appengine/findit/handlers/culprit.py b/appengine/findit/handlers/culprit.py
index 1575f0e24a46a586dfa3dd4d748d66dd56bc6aee..e759411141fea1d9947b5d07be1bf345e41b9323 100644
--- a/appengine/findit/handlers/culprit.py
+++ b/appengine/findit/handlers/culprit.py
@@ -36,8 +36,10 @@ class Culprit(BaseHandler):
data = {
'project_name': culprit.project_name,
'revision': culprit.revision,
+ 'commit_position': culprit.commit_position,
'cr_notified': culprit.cr_notified,
'cr_notification_time': _FormatDatetime(culprit.cr_notification_time),
'builds': map(ConvertBuildInfoToADict, culprit.builds),
+ 'key': key,
}
return {'template': 'waterfall/culprit.html', 'data': data}
« no previous file with comments | « appengine/findit/common/rietveld.py ('k') | appengine/findit/handlers/test/culprit_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698