[Findit] Fix redirect bug and update template for waterfall/culprit.

appengine/findit/waterfall/buildbot.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 from datetime import datetime
 import gzip
 import json
 import re
 import urllib
@@ skipping 160 matching lines @@
   for item in properties:
     if item[0] == property_name:
       return item[1]
   return None
 
 
 def GetBuildStartTime(build_data_json):
   times = build_data_json.get('times')
   if not times:
     return None
-  # TODO: convert to PST time?
   return datetime.utcfromtimestamp(times[0])
 
 
+def GetBuildEndTime(build_data_json):
+  times = build_data_json.get('times')
+  if not times or len(times) < 2 or not times[1]:
+    return None
+  return datetime.utcfromtimestamp(times[1])
+
+
 def GetBuildResult(build_data_json):
   return build_data_json.get('results')
 
 
 def ExtractBuildInfo(master_name, builder_name, build_number, build_data):
   """Extracts and returns build information as an instance of BuildInfo."""
   build_info = BuildInfo(master_name, builder_name, build_number)
 
   data_json = json.loads(build_data)
   chromium_revision = GetBuildProperty(
       data_json.get('properties', []), 'got_revision')
 
   build_info.build_start_time = GetBuildStartTime(data_json)
+  build_info.build_end_time = GetBuildEndTime(data_json)
   build_info.chromium_revision = chromium_revision
   build_info.completed = data_json.get('currentStep') is None
   build_info.result = GetBuildResult(data_json)
 
   changes = data_json.get('sourceStamp', {}).get('changes', [])
   for change in changes:
     if change['revision'] not in build_info.blame_list:
       build_info.blame_list.append(change['revision'])
 
   # Step categories:
@@ skipping 21 matching lines @@
       # the annotating step like "steps" fail too. Such annotating steps have a
       # log with name "preamble".
       continue
 
     if step_result in (SUCCESS, WARNINGS):
       build_info.passed_steps.append(step_name)
     elif step_result == FAILURE:
       build_info.failed_steps.append(step_name)
 
   return build_info