Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: appengine/findit/handlers/test/culprit_test.py

Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add one unittest. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/culprit.py ('k') | appengine/findit/main.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/test/culprit_test.py
diff --git a/appengine/findit/handlers/test/culprit_test.py b/appengine/findit/handlers/test/culprit_test.py
index ff705d5848c455f64649cc3553dab5a886b0ebba..da611430f311cf60096be2db93ddb3d3792ee1f3 100644
--- a/appengine/findit/handlers/test/culprit_test.py
+++ b/appengine/findit/handlers/test/culprit_test.py
@@ -18,7 +18,7 @@ class CulpritTest(testing.AppengineTestCase):
[('/culprit', culprit.Culprit), ], debug=True)
def testGetCulpritSuccess(self):
- wf_culprit = WfCulprit.Create('chromium', 'r1')
+ wf_culprit = WfCulprit.Create('chromium', 'r1', 123)
wf_culprit.builds.append(['m', 'b1', 1])
wf_culprit.builds.append(['m', 'b2', 2])
wf_culprit.cr_notification_status = status.COMPLETED
@@ -28,6 +28,7 @@ class CulpritTest(testing.AppengineTestCase):
expected_result = {
'project_name': 'chromium',
'revision': 'r1',
+ 'commit_position': 123,
'cr_notified': True,
'cr_notification_time': '2016-06-24 10:03:00 UTC',
'builds': [
@@ -42,6 +43,7 @@ class CulpritTest(testing.AppengineTestCase):
'build_number': 2,
},
],
+ 'key': wf_culprit.key.urlsafe(),
}
response = self.test_app.get(
« no previous file with comments | « appengine/findit/handlers/culprit.py ('k') | appengine/findit/main.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698