Chromium Code Reviews Chromium Code Reviews
Issue 2116073002:
[Findit] Fix redirect bug and update template for waterfall/culprit. (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <head> | 2 <head> |
| 3 <title>Culprit</title> | 3 <title>Culprit</title> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="stylesheet" href="/common.css"> | 5 <link rel="stylesheet" href="/common.css"> |
| 6 </head> | 6 </head> |
| 7 <body> | 7 <body> |
| 8 <h1>Culprit</h1> | 8 <h1>Culprit</h1> |
| 9 <b>Project:</b> {{project_name}}<br> | 9 <b>Project:</b> {{project_name}}<br> |
| 10 <b>Revision:</b><a href="https://crrev.com/{{revision}}">{{revision}}</a><br> | 10 <b>Commit:</b> <a href="https://crrev.com/{{commit_position or revision}}">{{c ommit_position or revision}}</a><br> |
| 11 {% if cr_notified %} | 11 {% if cr_notified %} |
| 12 <b>Notified:</b> Yes<br> | 12 <b>Notified:</b> Yes<br> |
| 13 <b>Notification time:</b> {{cr_notification_time}}<br> | 13 <b>Notification time:</b> {{cr_notification_time}}<br> |
| 14 {% else %} | 14 {% else %} |
| 15 <b>Notified:</b> No<br> | 15 <b>Notified:</b> No<br> |
| 16 {% endif %} | 16 {% endif %} |
| 17 | 17 |
| 18 <h1>Builds</h1> | 18 <h1>Builds</h1> |
| 19 <div id="builds"> | 19 <div id="builds"> |
| 20 <table> | 20 <table> |
| 21 <thead> | 21 <thead> |
| 22 <th></th> | 22 <th></th> |
| 23 <th>Master</th> | 23 <th>Master</th> |
| 24 <th>Builder</th> | 24 <th>Builder</th> |
| 25 <th>Build Number</th> | 25 <th>Build Number</th> |
| 26 <th>Findit Result</th> | |
| 26 </thead> | 27 </thead> |
| 27 <tbody> | 28 <tbody> |
| 28 {% for build in builds %} | 29 {% for build in builds %} |
| 29 <tr> | 30 <tr> |
| 30 <td>{{loop.index}}</td> | 31 <td>{{loop.index}}</td> |
| 31 <td>{{build.master_name}}</td> | 32 <td>{{build.master_name}}</td> |
| 32 <td>{{build.builder_name}}</td> | 33 <td>{{build.builder_name}}</td> |
| 33 <td> | 34 <td> |
| 34 <a href="/waterfall/build-failure?url=https://build.chromium.org/p | 35 <a href="https://build.chromium.org/p/{{build.master_name}}/builders /{{build.builder_name}}/builds/{{build.build_number}}"> |
| 35 /{{build.master_name}}/builders/{{build.builder_name}} | |
| 36 /builds/{{build.build_number}}"> | |
| 37 {{build.build_number}} | 36 {{build.build_number}} |
| 38 </a> | 37 </a> |
| 39 </td> | 38 </td> |
| 39 <td> | |
| 40 <a href="/waterfall/build-failure?url=https://build.chromium.org/p/{ {build.master_name}}/builders/{{build.builder_name}}/builds/{{build.build_number }}"> | |
| 41 Analysis | |
|
chanli
2016/07/01 20:17:36
nit: Since the header is 'Findit Result', I'm not
stgao
2016/07/01 22:47:30
After a second thought, this link seems not useful
| |
| 42 </a> | |
| 43 </td> | |
| 40 </tr> | 44 </tr> |
| 41 {% endfor %} | 45 {% endfor %} |
| 42 </tbody> | 46 </tbody> |
| 43 </table> | 47 </table> |
| 44 </div> | 48 </div> |
| 49 <br> | |
| 50 <a href="https://bugs.chromium.org/p/chromium/issues/entry?status=Available&la bels=findit-for-waterfall&components=Tools>Test>Findit>WrongResult&summary=Wrong Findit result for {{commit_position or revision}}&comment=Detail is https://fin dit-for-me.appspot.com/waterfall/culprit?key={{key}}&cc=stgao@chromium.org,chanl i@chromium.org,lijeffrey@chromium.org">File a bug for wrong Findit result!</a> | |
| 45 </body> | 51 </body> |
| OLD | NEW |
