Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: appengine/findit/handlers/culprit.py

Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add one unittest. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/common/rietveld.py ('k') | appengine/findit/handlers/test/culprit_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from google.appengine.ext import ndb 5 from google.appengine.ext import ndb
6 6
7 from common.base_handler import BaseHandler 7 from common.base_handler import BaseHandler
8 from common.base_handler import Permission 8 from common.base_handler import Permission
9 9
10 10
(...skipping 18 matching lines...) Expand all
29 def ConvertBuildInfoToADict(build_info): 29 def ConvertBuildInfoToADict(build_info):
30 return { 30 return {
31 'master_name': build_info[0], 31 'master_name': build_info[0],
32 'builder_name': build_info[1], 32 'builder_name': build_info[1],
33 'build_number': build_info[2], 33 'build_number': build_info[2],
34 } 34 }
35 35
36 data = { 36 data = {
37 'project_name': culprit.project_name, 37 'project_name': culprit.project_name,
38 'revision': culprit.revision, 38 'revision': culprit.revision,
39 'commit_position': culprit.commit_position,
39 'cr_notified': culprit.cr_notified, 40 'cr_notified': culprit.cr_notified,
40 'cr_notification_time': _FormatDatetime(culprit.cr_notification_time), 41 'cr_notification_time': _FormatDatetime(culprit.cr_notification_time),
41 'builds': map(ConvertBuildInfoToADict, culprit.builds), 42 'builds': map(ConvertBuildInfoToADict, culprit.builds),
43 'key': key,
42 } 44 }
43 return {'template': 'waterfall/culprit.html', 'data': data} 45 return {'template': 'waterfall/culprit.html', 'data': data}
OLDNEW
« no previous file with comments | « appengine/findit/common/rietveld.py ('k') | appengine/findit/handlers/test/culprit_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698