appengine/findit/templates/waterfall/culprit.html - Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/templates/waterfall/culprit.html

Issue 2116073002: [Findit] Fix redirect bug and update template for waterfall/culprit. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Add one unittest. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/templates/waterfall/culprit.html

diff --git a/appengine/findit/templates/waterfall/culprit.html b/appengine/findit/templates/waterfall/culprit.html

index 62562342870ae26629915faa043204d1edf3d48b..b5968ba99ff68018b2146277add628739d157bec 100644

--- a/appengine/findit/templates/waterfall/culprit.html

+++ b/appengine/findit/templates/waterfall/culprit.html

@@ -7,7 +7,7 @@

<body>

<h1>Culprit</h1>

<b>Project:</b> {{project_name}}<br>

- <b>Revision:</b><a href="https://crrev.com/{{revision}}">{{revision}}</a><br>

+ <b>Commit:</b> <a href="https://crrev.com/{{commit_position or revision}}">{{commit_position or revision}}</a><br>

{% if cr_notified %}

<b>Notified:</b> Yes<br>

<b>Notification time:</b> {{cr_notification_time}}<br>

@@ -22,7 +22,7 @@

<th>Master</th>

<th>Builder</th>

- <th>Build Number</th>

+ <th>Build</th>

</thead>

<tbody>

{% for build in builds %}

@@ -31,9 +31,7 @@

<td>{{build.master_name}}</td>

<td>{{build.builder_name}}</td>

<td>

- <a href="/waterfall/build-failure?url=https://build.chromium.org/p

-/{{build.master_name}}/builders/{{build.builder_name}}

-/builds/{{build.build_number}}">

+ <a href="https://build.chromium.org/p/{{build.master_name}}/builders/{{build.builder_name}}/builds/{{build.build_number}}">

</a>

</td>

@@ -42,4 +40,6 @@

</tbody>

</table>

</div>

+ <br>

+ <a href="https://bugs.chromium.org/p/chromium/issues/entry?status=Available&labels=findit-for-waterfall&components=Tools>Test>Findit>WrongResult&summary=Wrong Findit result for {{commit_position or revision}}&comment=Detail is https://findit-for-me.appspot.com/waterfall/culprit?key={{key}}&cc=stgao@chromium.org,chanli@chromium.org,lijeffrey@chromium.org">File a bug for wrong Findit result!</a>

</body>

« no previous file with comments | « appengine/findit/model/wf_culprit.py ('k') | appengine/findit/waterfall/build_info.py » ('j') | no next file with comments »