Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed)

Created:
4 years, 5 months ago by siva
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Land Ivan's change of 'Remove support for verified memory handling' R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/006bab2c477e7337f34e60a0f89d9f36a3e839a0

Patch Set 1 #

Patch Set 2 : Use no barrier store in PustArgumentsArray as we will be removing the tenure stuff which means arra… #

Patch Set 3 : Land Ivan's change of 'Remove support for verified memory handling' #

Total comments: 2

Patch Set 4 : Address code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -922 lines) Patch
M runtime/vm/assembler_arm.h View 3 chunks +8 lines, -48 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 3 7 chunks +29 lines, -152 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 4 chunks +2 lines, -35 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 2 3 7 chunks +5 lines, -137 lines 0 comments Download
M runtime/vm/assembler_x64.h View 4 chunks +2 lines, -35 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 3 6 chunks +6 lines, -140 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_dbc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/freelist.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/freelist.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +7 lines, -21 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 4 chunks +8 lines, -15 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 3 4 chunks +5 lines, -10 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/object.cc View 6 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/pages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/pages.cc View 3 chunks +1 line, -19 lines 0 comments Download
M runtime/vm/raw_object.h View 3 chunks +2 lines, -22 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M runtime/vm/redundancy_elimination.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/scavenger.cc View 7 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/snapshot.cc View 3 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 3 8 chunks +12 lines, -11 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 3 7 chunks +12 lines, -10 lines 0 comments Download
D runtime/vm/verified_memory.h View 1 chunk +0 lines, -90 lines 0 comments Download
D runtime/vm/verified_memory.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M runtime/vm/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
D tests/standalone/verified_mem_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 5 months ago (2016-06-30 23:38:20 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/2112043002/diff/40001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2112043002/diff/40001/tests/standalone/standalone.status#newcode20 tests/standalone/standalone.status:20: verified_mem_test: Pass, Slow, Timeout # Does verify before ...
4 years, 5 months ago (2016-06-30 23:44:22 UTC) #3
siva
https://codereview.chromium.org/2112043002/diff/40001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2112043002/diff/40001/tests/standalone/standalone.status#newcode20 tests/standalone/standalone.status:20: verified_mem_test: Pass, Slow, Timeout # Does verify before and ...
4 years, 5 months ago (2016-07-01 00:32:12 UTC) #4
siva
4 years, 5 months ago (2016-07-01 16:21:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
006bab2c477e7337f34e60a0f89d9f36a3e839a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698