runtime/vm/intermediate_language_mips.cc - Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address code review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_mips.cc

diff --git a/runtime/vm/intermediate_language_mips.cc b/runtime/vm/intermediate_language_mips.cc

index 6b9100bebdd948ad75822bea4bece953bf60af6f..342e267f6a438de6ea9edc5fa4bbca72e6aec53f 100644

--- a/runtime/vm/intermediate_language_mips.cc

+++ b/runtime/vm/intermediate_language_mips.cc

@@ -1922,7 +1922,7 @@ LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Zone* zone,

((IsPotentialUnboxedStore()) ? 3 : 0);

LocationSummary* summary = new(zone) LocationSummary(

zone, kNumInputs, kNumTemps,

- ((IsUnboxedStore() && opt && is_potential_unboxed_initialization_) ||

+ ((IsUnboxedStore() && opt && is_initialization()) ||

IsPotentialUnboxedStore())

? LocationSummary::kCallOnSlowPath

: LocationSummary::kNoCall);

@@ -1978,7 +1978,7 @@ void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

const intptr_t cid = field().UnboxedFieldCid();

- if (is_potential_unboxed_initialization_) {

+ if (is_initialization()) {

const Class* cls = NULL;

switch (cid) {

case kDoubleCid:

« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »