Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: runtime/vm/snapshot.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/scavenger.cc ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.cc
diff --git a/runtime/vm/snapshot.cc b/runtime/vm/snapshot.cc
index a041609c391f29f5137bc2b24ba97e3e343ab93c..41959955949172ca7d6645626533c034a5227e5f 100644
--- a/runtime/vm/snapshot.cc
+++ b/runtime/vm/snapshot.cc
@@ -19,7 +19,6 @@
#include "vm/stub_code.h"
#include "vm/symbols.h"
#include "vm/timeline.h"
-#include "vm/verified_memory.h"
#include "vm/version.h"
// We currently only expect the Dart mutator to read snapshots.
@@ -1428,12 +1427,8 @@ RawObject* SnapshotReader::AllocateUninitialized(intptr_t class_id,
ASSERT_NO_SAFEPOINT_SCOPE();
ASSERT(Utils::IsAligned(size, kObjectAlignment));
- // Allocate memory where all words look like smis. This is currently
- // only needed for DEBUG-mode validation in StorePointer/StoreSmi, but will
- // be essential with the upcoming deletion barrier.
uword address =
- old_space()->TryAllocateSmiInitializedLocked(size,
- PageSpace::kForceGrowth);
+ old_space()->TryAllocateDataBumpLocked(size, PageSpace::kForceGrowth);
if (address == 0) {
// Use the preallocated out of memory exception to avoid calling
// into dart code or allocating any code.
@@ -1443,7 +1438,6 @@ RawObject* SnapshotReader::AllocateUninitialized(intptr_t class_id,
object_store()->preallocated_unhandled_exception());
thread()->long_jump_base()->Jump(1, error);
}
- VerifiedMemory::Accept(address, size);
RawObject* raw_obj = reinterpret_cast<RawObject*>(address + kHeapObjectTag);
uword tags = 0;
« no previous file with comments | « runtime/vm/scavenger.cc ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698