Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: runtime/vm/intermediate_language.h

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/freelist.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 2705634bd7f5fa665ec9947a14f58b42bb849e66..44cf12105cf01270e0234bed5f0bff6c10071549 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -3581,8 +3581,7 @@ class StoreInstanceFieldInstr : public TemplateDefinition<2, NoThrow> {
offset_in_bytes_(field.Offset()),
emit_store_barrier_(emit_store_barrier),
token_pos_(token_pos),
- is_potential_unboxed_initialization_(false),
- is_object_reference_initialization_(false) {
+ is_initialization_(false) {
SetInputAt(kInstancePos, instance);
SetInputAt(kValuePos, value);
CheckField(field);
@@ -3597,20 +3596,14 @@ class StoreInstanceFieldInstr : public TemplateDefinition<2, NoThrow> {
offset_in_bytes_(offset_in_bytes),
emit_store_barrier_(emit_store_barrier),
token_pos_(token_pos),
- is_potential_unboxed_initialization_(false),
- is_object_reference_initialization_(false) {
+ is_initialization_(false) {
SetInputAt(kInstancePos, instance);
SetInputAt(kValuePos, value);
}
DECLARE_INSTRUCTION(StoreInstanceField)
- void set_is_potential_unboxed_initialization(bool value) {
- is_potential_unboxed_initialization_ = value;
- }
- void set_is_object_reference_initialization(bool value) {
- is_object_reference_initialization_ = value;
- }
+ void set_is_initialization(bool value) { is_initialization_ = value; }
enum {
kInstancePos = 0,
@@ -3619,12 +3612,8 @@ class StoreInstanceFieldInstr : public TemplateDefinition<2, NoThrow> {
Value* instance() const { return inputs_[kInstancePos]; }
Value* value() const { return inputs_[kValuePos]; }
- bool is_potential_unboxed_initialization() const {
- return is_potential_unboxed_initialization_;
- }
- bool is_object_reference_initialization() const {
- return is_object_reference_initialization_;
- }
+ bool is_initialization() const { return is_initialization_; }
+
virtual TokenPosition token_pos() const { return token_pos_; }
const Field& field() const { return field_; }
@@ -3669,11 +3658,8 @@ class StoreInstanceFieldInstr : public TemplateDefinition<2, NoThrow> {
intptr_t offset_in_bytes_;
const StoreBarrierType emit_store_barrier_;
const TokenPosition token_pos_;
- // This may be the first store to an unboxed field.
- bool is_potential_unboxed_initialization_;
- // True if this store initializes an object reference field of an object that
- // was allocated uninitialized; see AllocateUninitializedContext.
- bool is_object_reference_initialization_;
+ // Marks initialiing stores. E.g. in the constructor.
+ bool is_initialization_;
DISALLOW_COPY_AND_ASSIGN(StoreInstanceFieldInstr);
};
« no previous file with comments | « runtime/vm/freelist.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698