runtime/vm/flow_graph_compiler_arm.cc - Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address code review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_arm.cc

diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc

index 269e66839e489cbeb668271e6ea9db8ee47fc388..4162943e1fd01f5c16da5a3f375079bcfe0c158d 100644

--- a/runtime/vm/flow_graph_compiler_arm.cc

+++ b/runtime/vm/flow_graph_compiler_arm.cc

@@ -20,7 +20,6 @@

#include "vm/stack_frame.h"

#include "vm/stub_code.h"

#include "vm/symbols.h"

-#include "vm/verified_memory.h"

namespace dart {

@@ -1252,8 +1251,7 @@ void FlowGraphCompiler::EmitEdgeCounter(intptr_t edge_id) {

#endif // DEBUG

__ LoadFieldFromOffset(kWord, R1, R0, Array::element_offset(edge_id));

__ add(R1, R1, Operand(Smi::RawValue(1)));

- __ StoreIntoObjectNoBarrierOffset(

- R0, Array::element_offset(edge_id), R1, Assembler::kOnlySmi);

+ __ StoreIntoObjectNoBarrierOffset(R0, Array::element_offset(edge_id), R1);

#if defined(DEBUG)

assembler_->set_use_far_branches(old_use_far_branches);

#endif // DEBUG

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_compiler_dbc.cc » ('j') | no next file with comments »