Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: runtime/vm/assembler_arm.h

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.h
diff --git a/runtime/vm/assembler_arm.h b/runtime/vm/assembler_arm.h
index 66e7c13790a8e55aa63cf597bfde95ad7ee95b86..cac760b0c8dd89d605a0c45638c7317242b833a6 100644
--- a/runtime/vm/assembler_arm.h
+++ b/runtime/vm/assembler_arm.h
@@ -744,14 +744,6 @@ class Assembler : public ValueObject {
void PushObject(const Object& object);
void CompareObject(Register rn, const Object& object);
- // When storing into a heap object field, knowledge of the previous content
- // is expressed through these constants.
- enum FieldContent {
- kEmptyOrSmiOrNull, // Empty = garbage/zapped in release/debug mode.
- kHeapObjectOrSmi,
- kOnlySmi,
- };
-
void StoreIntoObject(Register object, // Object we are storing into.
const Address& dest, // Where we are storing into.
Register value, // Value we are storing.
@@ -763,27 +755,16 @@ class Assembler : public ValueObject {
void StoreIntoObjectNoBarrier(Register object,
const Address& dest,
- Register value,
- FieldContent old_content = kHeapObjectOrSmi);
- void InitializeFieldNoBarrier(Register object,
- const Address& dest,
- Register value) {
- StoreIntoObjectNoBarrier(object, dest, value, kEmptyOrSmiOrNull);
- }
- void StoreIntoObjectNoBarrierOffset(
- Register object,
- int32_t offset,
- Register value,
- FieldContent old_content = kHeapObjectOrSmi);
+ Register value);
void StoreIntoObjectNoBarrier(Register object,
const Address& dest,
- const Object& value,
- FieldContent old_content = kHeapObjectOrSmi);
- void StoreIntoObjectNoBarrierOffset(
- Register object,
- int32_t offset,
- const Object& value,
- FieldContent old_content = kHeapObjectOrSmi);
+ const Object& value);
+ void StoreIntoObjectNoBarrierOffset(Register object,
+ int32_t offset,
+ Register value);
+ void StoreIntoObjectNoBarrierOffset(Register object,
+ int32_t offset,
+ const Object& value);
// Store value_even, value_odd, value_even, ... into the words in the address
// range [begin, end), assumed to be uninitialized fields in object (tagged).
@@ -1193,27 +1174,6 @@ class Assembler : public ValueObject {
Register value,
Label* no_update);
- // Helpers for write-barrier verification.
-
- // Returns VerifiedMemory::offset() as an Operand.
- Operand GetVerifiedMemoryShadow();
- // Writes value to [base + offset] and also its shadow location, if enabled.
- void WriteShadowedField(Register base,
- intptr_t offset,
- Register value,
- Condition cond = AL);
- void WriteShadowedFieldPair(Register base,
- intptr_t offset,
- Register value_even,
- Register value_odd,
- Condition cond = AL);
- // Writes new_value to address and its shadow location, if enabled, after
- // verifying that its old value matches its shadow.
- void VerifiedWrite(Register object,
- const Address& address,
- Register new_value,
- FieldContent old_content);
-
DISALLOW_ALLOCATION();
DISALLOW_COPY_AND_ASSIGN(Assembler);
};
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698