Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "lib/invocation_mirror.h" 7 #include "lib/invocation_mirror.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 3642 matching lines...) Expand 10 before | Expand all | Expand 10 after
3653 AddInstruction(guard_field_length); 3653 AddInstruction(guard_field_length);
3654 store_value = Bind(BuildLoadExprTemp(token_pos)); 3654 store_value = Bind(BuildLoadExprTemp(token_pos));
3655 } 3655 }
3656 StoreInstanceFieldInstr* store = 3656 StoreInstanceFieldInstr* store =
3657 new(Z) StoreInstanceFieldInstr(node->field(), 3657 new(Z) StoreInstanceFieldInstr(node->field(),
3658 for_instance.value(), 3658 for_instance.value(),
3659 store_value, 3659 store_value,
3660 kEmitStoreBarrier, 3660 kEmitStoreBarrier,
3661 token_pos); 3661 token_pos);
3662 // Maybe initializing unboxed store. 3662 // Maybe initializing unboxed store.
3663 store->set_is_potential_unboxed_initialization(true); 3663 store->set_is_initialization(true);
3664 ReturnDefinition(store); 3664 ReturnDefinition(store);
3665 } 3665 }
3666 3666
3667 3667
3668 void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) { 3668 void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) {
3669 const TokenPosition token_pos = node->token_pos(); 3669 const TokenPosition token_pos = node->token_pos();
3670 if (node->field().is_const()) { 3670 if (node->field().is_const()) {
3671 ASSERT(node->field().StaticValue() != Object::sentinel().raw()); 3671 ASSERT(node->field().StaticValue() != Object::sentinel().raw());
3672 ASSERT(node->field().StaticValue() != 3672 ASSERT(node->field().StaticValue() !=
3673 Object::transition_sentinel().raw()); 3673 Object::transition_sentinel().raw());
(...skipping 907 matching lines...) Expand 10 before | Expand all | Expand 10 after
4581 block_marks); 4581 block_marks);
4582 ASSERT(found); 4582 ASSERT(found);
4583 } 4583 }
4584 4584
4585 4585
4586 void FlowGraphBuilder::Bailout(const char* reason) const { 4586 void FlowGraphBuilder::Bailout(const char* reason) const {
4587 parsed_function_.Bailout("FlowGraphBuilder", reason); 4587 parsed_function_.Bailout("FlowGraphBuilder", reason);
4588 } 4588 }
4589 4589
4590 } // namespace dart 4590 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698