Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1711)

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm.cc
diff --git a/runtime/vm/intrinsifier_arm.cc b/runtime/vm/intrinsifier_arm.cc
index 13b474a0133e59696dc02bf7db37eca1458d6ad1..be7a6b2cf7bd048b7b7feb8b69c745033ead163b 100644
--- a/runtime/vm/intrinsifier_arm.cc
+++ b/runtime/vm/intrinsifier_arm.cc
@@ -103,7 +103,7 @@ void Intrinsifier::GrowableArray_Allocate(Assembler* assembler) {
// Store backing array object in growable array object.
__ ldr(R1, Address(SP, kArrayOffset)); // Data argument.
// R0 is new, no barrier needed.
- __ InitializeFieldNoBarrier(
+ __ StoreIntoObjectNoBarrier(
R0,
FieldAddress(R0, GrowableObjectArray::data_offset()),
R1);
@@ -111,14 +111,14 @@ void Intrinsifier::GrowableArray_Allocate(Assembler* assembler) {
// R0: new growable array object start as a tagged pointer.
// Store the type argument field in the growable array object.
__ ldr(R1, Address(SP, kTypeArgumentsOffset)); // Type argument.
- __ InitializeFieldNoBarrier(
+ __ StoreIntoObjectNoBarrier(
R0,
FieldAddress(R0, GrowableObjectArray::type_arguments_offset()),
R1);
// Set the length field in the growable array object to 0.
__ LoadImmediate(R1, 0);
- __ InitializeFieldNoBarrier(
+ __ StoreIntoObjectNoBarrier(
R0,
FieldAddress(R0, GrowableObjectArray::length_offset()),
R1);
@@ -227,7 +227,7 @@ void Intrinsifier::GrowableArray_add(Assembler* assembler) {
/* R2: allocation size. */ \
/* R4: allocation stats address. */ \
__ ldr(R3, Address(SP, kArrayLengthStackOffset)); /* Array length. */ \
- __ InitializeFieldNoBarrier(R0, \
+ __ StoreIntoObjectNoBarrier(R0, \
FieldAddress(R0, type_name::length_offset()), \
R3); \
/* Initialize all array elements to 0. */ \
@@ -1876,12 +1876,12 @@ static void TryAllocateOnebyteString(Assembler* assembler,
}
// Set the length field using the saved length (R8).
- __ InitializeFieldNoBarrier(R0,
+ __ StoreIntoObjectNoBarrier(R0,
FieldAddress(R0, String::length_offset()),
R8);
// Clear hash.
__ LoadImmediate(TMP, 0);
- __ InitializeFieldNoBarrier(R0,
+ __ StoreIntoObjectNoBarrier(R0,
FieldAddress(R0, String::hash_offset()),
TMP);
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698