Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2111793002: Simplify JIT event logging. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify JIT event logging. R=jgruber@chromium.org BUG=v8:5117 Committed: https://crrev.com/bcb5b3d550c744e119e412c46e03f9800f1b619e Cr-Commit-Position: refs/heads/master@{#37435}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Patch Set 3 : fix forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -72 lines) Patch
M src/compiler/code-generator.cc View 3 chunks +1 line, -9 lines 0 comments Download
M src/crankshaft/lithium.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/interpreter/bytecode-array-writer.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M src/log.h View 4 chunks +2 lines, -23 lines 0 comments Download
M src/log.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/source-position-table.h View 1 2 3 chunks +8 lines, -11 lines 0 comments Download
M src/source-position-table.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
Yang
4 years, 5 months ago (2016-06-30 07:39:16 UTC) #1
jgruber
LGTMwC https://codereview.chromium.org/2111793002/diff/1/src/source-position-table.h File src/source-position-table.h (right): https://codereview.chromium.org/2111793002/diff/1/src/source-position-table.h#newcode11 src/source-position-table.h:11: #include "src/log.h" Can we move this to the ...
4 years, 5 months ago (2016-06-30 08:49:19 UTC) #2
jgruber
lgtm
4 years, 5 months ago (2016-06-30 08:49:32 UTC) #3
Yang
https://codereview.chromium.org/2111793002/diff/1/src/source-position-table.h File src/source-position-table.h (right): https://codereview.chromium.org/2111793002/diff/1/src/source-position-table.h#newcode11 src/source-position-table.h:11: #include "src/log.h" On 2016/06/30 08:49:18, jgruber wrote: > Can ...
4 years, 5 months ago (2016-06-30 09:00:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111793002/40001
4 years, 5 months ago (2016-06-30 09:06:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18512)
4 years, 5 months ago (2016-06-30 09:11:05 UTC) #9
Benedikt Meurer
LGTM (gummi-gestempelt)
4 years, 5 months ago (2016-06-30 09:26:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111793002/40001
4 years, 5 months ago (2016-06-30 10:33:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 11:17:14 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 11:17:35 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bcb5b3d550c744e119e412c46e03f9800f1b619e
Cr-Commit-Position: refs/heads/master@{#37435}

Powered by Google App Engine
This is Rietveld 408576698