Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: src/source-position-table.h

Issue 2111793002: Simplify JIT event logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix forward declaration Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.cc ('k') | src/source-position-table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/source-position-table.h
diff --git a/src/source-position-table.h b/src/source-position-table.h
index 65fe782031eedd486f5c730453ecfd3a1be692aa..bd822410cb67c4c8f4511e0d60d6c3d24df5e61e 100644
--- a/src/source-position-table.h
+++ b/src/source-position-table.h
@@ -8,12 +8,12 @@
#include "src/assert-scope.h"
#include "src/checks.h"
#include "src/handles.h"
-#include "src/log.h"
#include "src/zone-containers.h"
namespace v8 {
namespace internal {
+class AbstractCode;
class BytecodeArray;
class ByteArray;
class Isolate;
@@ -30,23 +30,17 @@ struct PositionTableEntry {
bool is_statement;
};
-class SourcePositionTableBuilder final : public PositionsRecorder {
+class SourcePositionTableBuilder {
public:
- SourcePositionTableBuilder(Isolate* isolate, Zone* zone)
- : isolate_(isolate),
- bytes_(zone),
-#ifdef ENABLE_SLOW_DCHECKS
- raw_entries_(zone),
-#endif
- previous_() {
- }
+ SourcePositionTableBuilder(Isolate* isolate, Zone* zone);
+
+ void EndJitLogging(AbstractCode* code);
void AddPosition(size_t code_offset, int source_position, bool is_statement);
Handle<ByteArray> ToSourcePositionTable();
private:
void AddEntry(const PositionTableEntry& entry);
- void CommitEntry();
Isolate* isolate_;
ZoneVector<byte> bytes_;
@@ -54,6 +48,9 @@ class SourcePositionTableBuilder final : public PositionsRecorder {
ZoneVector<PositionTableEntry> raw_entries_;
#endif
PositionTableEntry previous_; // Previously written entry, to compute delta.
+ // Currently jit_handler_data_ is used to store JITHandler-specific data
+ // over the lifetime of a SourcePositionTableBuilder.
+ void* jit_handler_data_;
};
class SourcePositionTableIterator {
« no previous file with comments | « src/log.cc ('k') | src/source-position-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698