Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: src/crankshaft/lithium.cc

Issue 2111793002: Simplify JIT event logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix forward declaration Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/lithium.cc
diff --git a/src/crankshaft/lithium.cc b/src/crankshaft/lithium.cc
index 8804da7838eee3d53b443147aa2fdd933d208394..0bb4ed98d317d1c439a18426498696882e663edc 100644
--- a/src/crankshaft/lithium.cc
+++ b/src/crankshaft/lithium.cc
@@ -452,10 +452,6 @@ Handle<Code> LChunk::Codegen() {
DCHECK(!info()->will_serialize());
LCodeGen generator(this, &assembler, info());
- LOG_CODE_EVENT(info()->isolate(),
- CodeStartLinePosInfoRecordEvent(
- generator.source_position_table_builder()));
-
MarkEmptyBlocks();
if (generator.GenerateCode()) {
@@ -464,12 +460,9 @@ Handle<Code> LChunk::Codegen() {
Handle<Code> code = CodeGenerator::MakeCodeEpilogue(&assembler, info());
generator.FinishCode(code);
CommitDependencies(code);
+ generator.source_position_table_builder()->EndJitLogging(
+ AbstractCode::cast(*code));
code->set_is_crankshafted(true);
- void* jit_handler_data =
- generator.source_position_table_builder()->DetachJITHandlerData();
- LOG_CODE_EVENT(info()->isolate(),
- CodeEndLinePosInfoRecordEvent(AbstractCode::cast(*code),
- jit_handler_data));
CodeGenerator::PrintCode(code, info());
DCHECK(!(info()->GetMustNotHaveEagerFrame() &&
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698