Do not record source positions for non-JS or native script code.

Do not record source positions for non-script or native script compiles.

R=bmeurer@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org

Committed: https://crrev.com/3885fa09741fb3400f0dcce0e91e458b40d236aa
Cr-Commit-Position: refs/heads/master@{#37602}

[Yang, 2016-06-30 10:28:20]

Motivation is that we never use the source position for these code objects. And
we should not, since they should be able to be substituted by C++ built-ins.

This reduces the memory we spend on source positions from ~47kB to ~36kB when
running the sunspider benchmark.

[oth, 2016-06-30 11:18:44]

On 2016/06/30 10:28:20, Yang wrote:
> Motivation is that we never use the source position for these code objects.
And
> we should not, since they should be able to be substituted by C++ built-ins.
> 
> This reduces the memory we spend on source positions from ~47kB to ~36kB when
> running the sunspider benchmark.

DBQ - Might it be worth suppressing the emission of source positions in the
bytecode
array builder in this instance? It opens up more bytecode optimization
opportunities
though unclear here how much code that actually represents.

[Yang, 2016-06-30 11:20:00]

On 2016/06/30 11:18:44, oth wrote:
> On 2016/06/30 10:28:20, Yang wrote:
> > Motivation is that we never use the source position for these code objects.
> And
> > we should not, since they should be able to be substituted by C++ built-ins.
> > 
> > This reduces the memory we spend on source positions from ~47kB to ~36kB
when
> > running the sunspider benchmark.
> 
> DBQ - Might it be worth suppressing the emission of source positions in the
> bytecode
> array builder in this instance? It opens up more bytecode optimization
> opportunities
> though unclear here how much code that actually represents.

We can definitely do that too. Should I include that it this CL or do you want
to do that in a follow-up CL?

[Benedikt Meurer, 2016-07-04 16:54:34]

LGTM on compilers.

[Yang, 2016-07-05 05:34:55]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 05:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 05:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 05:39:12]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Yang, 2016-07-06 08:39:57]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 08:40:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 08:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 08:57:32]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/8539)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Yang, 2016-07-07 12:51:40]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 12:51:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 13:23:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 13:23:31]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-07 13:25:13]

On 2016/07/07 13:23:31, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I can haz lgtms?

[Michael Starzinger, 2016-07-07 14:48:32]

LGTM from my end.

[Yang, 2016-07-08 08:46:18]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-07-08 08:46:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2112853002/#ps40001
(title: "update test expectation")

[commit-bot: I haz the power, 2016-07-08 08:46:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 08:48:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-08 08:49:54]

Description was changed from

==========
Do not record source positions for non-script or native script compiles.

R=bmeurer@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org
==========

to

==========
Do not record source positions for non-script or native script compiles.

R=bmeurer@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org

Committed: https://crrev.com/3885fa09741fb3400f0dcce0e91e458b40d236aa
Cr-Commit-Position: refs/heads/master@{#37602}
==========

[commit-bot: I haz the power, 2016-07-08 08:49:55]

Patchset 3 (id:??) landed as
https://crrev.com/3885fa09741fb3400f0dcce0e91e458b40d236aa
Cr-Commit-Position: refs/heads/master@{#37602}