Simplify JIT event logging.

src/log.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_LOG_H_
 #define V8_LOG_H_
 
 #include <string>
 
 #include "src/allocation.h"
@@ skipping 48 matching lines @@
 //
 // --prof
 // Collect statistical profiling information (ticks), default is off.  The
 // tick profiler requires code events, so --prof implies --log-code.
 
 // Forward declarations.
 class CodeEventListener;
 class CpuProfiler;
 class Isolate;
 class Log;
-class PositionsRecorder;
 class Profiler;
 class Ticker;
 struct TickSample;
 class RuntimeCallTimer;
 
 #undef LOG
 #define LOG(isolate, Call)                              \
   do {                                                  \
     v8::internal::Logger* logger = (isolate)->logger(); \
     if (logger->is_logging()) logger->Call;             \
@@ skipping 106 matching lines @@
   void CodeMoveEvent(AbstractCode* from, Address to);
   // Emits a code line info add event with Postion type.
   void CodeLinePosInfoAddPositionEvent(void* jit_handler_data,
                                        int pc_offset,
                                        int position);
   // Emits a code line info add event with StatementPostion type.
   void CodeLinePosInfoAddStatementPositionEvent(void* jit_handler_data,
                                                 int pc_offset,
                                                 int position);
   // Emits a code line info start to record event
-  void CodeStartLinePosInfoRecordEvent(PositionsRecorder* pos_recorder);
+  void CodeStartLinePosInfoRecordEvent(void** jit_handler_data_out);
   // Emits a code line info finish record event.
   // It's the callee's responsibility to dispose the parameter jit_handler_data.
   void CodeEndLinePosInfoRecordEvent(AbstractCode* code,
                                      void* jit_handler_data);
 
   void SharedFunctionInfoMoveEvent(Address from, Address to);
 
   void CodeNameEvent(Address addr, int pos, const char* code_name);
 
   void CodeDeoptEvent(Code* code, Address pc, int fp_to_sp_delta);
@@ skipping 137 matching lines @@
   std::unique_ptr<ProfilerListener> profiler_listener_;
   List<CodeEventListener*> listeners_;
 
   // Guards against multiple calls to TearDown() that can happen in some tests.
   // 'true' between SetUp() and TearDown().
   bool is_initialized_;
 
   base::ElapsedTimer timer_;
 
   friend class CpuProfiler;
+  friend class SourcePositionTableBuilder;
 };
 
 #define TIMER_EVENTS_LIST(V)    \
   V(RecompileSynchronous, true) \
   V(RecompileConcurrent, true)  \
   V(CompileIgnition, true)      \
   V(CompileFullCode, true)      \
   V(OptimizeCode, true)         \
   V(CompileCode, true)          \
   V(DeoptimizeCode, true)       \
@@ skipping 19 matching lines @@
   }
 
   ~TimerEventScope() { LogTimerEvent(Logger::END); }
 
   void LogTimerEvent(Logger::StartEnd se);
 
  private:
   Isolate* isolate_;
 };
 
-class PositionsRecorder BASE_EMBEDDED {
- public:
-  PositionsRecorder() { jit_handler_data_ = NULL; }
-
-  void AttachJITHandlerData(void* user_data) { jit_handler_data_ = user_data; }
-
-  void* DetachJITHandlerData() {
-    void* old_data = jit_handler_data_;
-    jit_handler_data_ = NULL;
-    return old_data;
-  }
-
- protected:
-  // Currently jit_handler_data_ is used to store JITHandler-specific data
-  // over the lifetime of a PositionsRecorder
-  void* jit_handler_data_;
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(PositionsRecorder);
-};
-
 class CodeEventLogger : public CodeEventListener {
  public:
   CodeEventLogger();
   ~CodeEventLogger() override;
 
   void CodeCreateEvent(LogEventsAndTags tag, AbstractCode* code,
                        const char* comment) override;
   void CodeCreateEvent(LogEventsAndTags tag, AbstractCode* code,
                        Name* name) override;
   void CodeCreateEvent(LogEventsAndTags tag, AbstractCode* code,
@@ skipping 20 matching lines @@
 
   NameBuffer* name_buffer_;
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 
 #endif  // V8_LOG_H_