Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: src/log.h

Issue 2111793002: Simplify JIT event logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix forward declaration Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-writer.cc ('k') | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 303e352898a0cd76a8774be863fbe787e3b56d65..93e8a4334182e3bca18144478fa572d15c2db838 100644
--- a/src/log.h
+++ b/src/log.h
@@ -66,7 +66,6 @@ class CodeEventListener;
class CpuProfiler;
class Isolate;
class Log;
-class PositionsRecorder;
class Profiler;
class Ticker;
struct TickSample;
@@ -193,7 +192,7 @@ class Logger : public CodeEventListener {
int pc_offset,
int position);
// Emits a code line info start to record event
- void CodeStartLinePosInfoRecordEvent(PositionsRecorder* pos_recorder);
+ void CodeStartLinePosInfoRecordEvent(void** jit_handler_data_out);
// Emits a code line info finish record event.
// It's the callee's responsibility to dispose the parameter jit_handler_data.
void CodeEndLinePosInfoRecordEvent(AbstractCode* code,
@@ -351,6 +350,7 @@ class Logger : public CodeEventListener {
base::ElapsedTimer timer_;
friend class CpuProfiler;
+ friend class SourcePositionTableBuilder;
};
#define TIMER_EVENTS_LIST(V) \
@@ -390,27 +390,6 @@ class TimerEventScope {
Isolate* isolate_;
};
-class PositionsRecorder BASE_EMBEDDED {
- public:
- PositionsRecorder() { jit_handler_data_ = NULL; }
-
- void AttachJITHandlerData(void* user_data) { jit_handler_data_ = user_data; }
-
- void* DetachJITHandlerData() {
- void* old_data = jit_handler_data_;
- jit_handler_data_ = NULL;
- return old_data;
- }
-
- protected:
- // Currently jit_handler_data_ is used to store JITHandler-specific data
- // over the lifetime of a PositionsRecorder
- void* jit_handler_data_;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(PositionsRecorder);
-};
-
class CodeEventLogger : public CodeEventListener {
public:
CodeEventLogger();
« no previous file with comments | « src/interpreter/bytecode-array-writer.cc ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698