Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: src/compiler/code-generator.cc

Issue 2111793002: Simplify JIT event logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix forward declaration Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/crankshaft/lithium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/code-generator.cc
diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc
index 74c97dfc5387059974e9eb521cbbfd7e6ffe702b..d89452f732d47f2ac5a9c9bc0863d8e677cf4967 100644
--- a/src/compiler/code-generator.cc
+++ b/src/compiler/code-generator.cc
@@ -73,10 +73,6 @@ Handle<Code> CodeGenerator::GenerateCode() {
// the frame (that is done in AssemblePrologue).
FrameScope frame_scope(masm(), StackFrame::MANUAL);
- // Emit a code line info recording start event.
- LOG_CODE_EVENT(isolate(), CodeStartLinePosInfoRecordEvent(
- &source_position_table_builder_));
-
// Place function entry hook if requested to do so.
if (linkage()->GetIncomingDescriptor()->IsJSFunctionCall()) {
ProfileEntryHookStub::MaybeCallEntryHook(masm());
@@ -213,6 +209,7 @@ Handle<Code> CodeGenerator::GenerateCode() {
Handle<ByteArray> source_positions =
source_position_table_builder_.ToSourcePositionTable();
result->set_source_position_table(*source_positions);
+ source_position_table_builder_.EndJitLogging(AbstractCode::cast(*result));
// Emit exception handler table.
if (!handlers_.empty()) {
@@ -238,11 +235,6 @@ Handle<Code> CodeGenerator::GenerateCode() {
Deoptimizer::EnsureRelocSpaceForLazyDeoptimization(result);
}
- // Emit a code line info recording stop event.
- void* line_info = source_position_table_builder_.DetachJITHandlerData();
- LOG_CODE_EVENT(isolate(), CodeEndLinePosInfoRecordEvent(
- AbstractCode::cast(*result), line_info));
-
return result;
}
« no previous file with comments | « no previous file | src/crankshaft/lithium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698