Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2111793002: Simplify JIT event logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix forward declaration Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/lithium.cc ('k') | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/full-codegen.cc
diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc
index 1632935c070175358cdf8eabeef0139b243ad64d..2dac2b6044c030247072682aebab4cf0e991eac0 100644
--- a/src/full-codegen/full-codegen.cc
+++ b/src/full-codegen/full-codegen.cc
@@ -46,8 +46,6 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) {
if (info->will_serialize()) masm.enable_serializer();
FullCodeGenerator cgen(&masm, info);
- LOG_CODE_EVENT(isolate, CodeStartLinePosInfoRecordEvent(
- &cgen.source_position_table_builder_));
cgen.Generate();
if (cgen.HasStackOverflow()) {
DCHECK(!isolate->has_pending_exception());
@@ -67,11 +65,9 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) {
Handle<ByteArray> source_positions =
cgen.source_position_table_builder_.ToSourcePositionTable();
code->set_source_position_table(*source_positions);
+ cgen.source_position_table_builder_.EndJitLogging(AbstractCode::cast(*code));
CodeGenerator::PrintCode(code, info);
info->SetCode(code);
- void* line_info = cgen.source_position_table_builder_.DetachJITHandlerData();
- LOG_CODE_EVENT(isolate, CodeEndLinePosInfoRecordEvent(
- AbstractCode::cast(*code), line_info));
#ifdef DEBUG
// Check that no context-specific object has been embedded.
« no previous file with comments | « src/crankshaft/lithium.cc ('k') | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698