Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, asanka, msramek+watch_chromium.org, skanuj+watch_chromium.org, felt, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, shishir+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, yzshen+watch_chromium.org, markusheintz_, ben+mojo_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, tommycli, grt+watch_chromium.org, tzik, abarth-chromium, rlp+watch_chromium.org, Jered, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, tapted, rouslan+autofill_chromium.org, nhiroki, media-router+watch_chromium.org, jfweitz+watch_chromium.org, rouslan+spell_chromium.org, mcasas+watch+vc_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, sync-reviews_chromium.org, mkwst+watchlist-passwords_chromium.org, feature-media-reviews_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Aaron Boodman, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, darin (slow to review), vabr+watchlistautofill_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in chrome. This CL makes the following replacements in chrome: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=thestig@chromium.org Committed: https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73 Cr-Commit-Position: refs/heads/master@{#401614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -252 lines) Patch
M chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/download/download_status_updater_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/top_sites/top_sites_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/app_data_migrator_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_icon_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/media/combined_desktop_media_list_unittest.cc View 12 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/media/native_desktop_media_list_unittest.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/tab_desktop_media_list_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_permissions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/net/quota_policy_channel_id_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/device_management_service_browsertest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_table_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/privet_http_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/privet_url_fetcher_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 49 chunks +49 lines, -49 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/status_change_checker.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/mac/mock_launchd.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/service/service_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/service/service_process_prefs_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/image_writer/disk_unmounter_mac.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:36:45 UTC) #1
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-23 14:55:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083363002/1
4 years, 6 months ago (2016-06-23 14:59:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 15:53:18 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 15:54:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb32419d7ec55e6c37379c4f1d0e969eefe38f73
Cr-Commit-Position: refs/heads/master@{#401614}

Powered by Google App Engine
This is Rietveld 408576698