chrome/browser/safe_browsing/client_side_detection_host_unittest.cc - Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

index 80e8d051da8deb2ef5654c69bea1b828a73b7505..3b1c94e0aa229572bd9e31483cf8272836a574fa 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

@@ -629,7 +629,7 @@ TEST_F(ClientSideDetectionHostTest, OnPhishingDetectionDoneMultiplePings) {

redirect_chain.push_back(other_phishing_url);

SetRedirectChain(redirect_chain);

OnPhishingDetectionDone(verdict.SerializeAsString());

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(Mock::VerifyAndClear(csd_host_.get()));

EXPECT_TRUE(Mock::VerifyAndClear(csd_service_.get()));

ASSERT_FALSE(cb_other.is_null());

@@ -706,7 +706,7 @@ TEST_F(ClientSideDetectionHostTest,

redirect_chain.push_back(url);

SetRedirectChain(redirect_chain);

OnPhishingDetectionDone(verdict.SerializeAsString());

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(Mock::VerifyAndClear(csd_host_.get()));

}

@@ -745,7 +745,7 @@ TEST_F(ClientSideDetectionHostTest,

redirect_chain.push_back(url);

SetRedirectChain(redirect_chain);

OnPhishingDetectionDone(verdict.SerializeAsString());

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(Mock::VerifyAndClear(csd_host_.get()));

ExpectPreClassificationChecks(start_url, &kFalse, &kFalse, &kFalse, &kFalse,

@@ -799,7 +799,7 @@ TEST_F(

redirect_chain.push_back(url);

SetRedirectChain(redirect_chain);

OnPhishingDetectionDone(verdict.SerializeAsString());

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(Mock::VerifyAndClear(csd_host_.get()));

}