Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
diff --git a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
index 53b1f76a6bbcc7b440e4841d94349203ec7d7011..6b9e759880d2a087fb02fc868a6e787e57e4b6f6 100644
--- a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
+++ b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
@@ -13,6 +13,7 @@
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
#include "components/policy/core/common/external_data_fetcher.h"
#include "components/policy/core/common/policy_map.h"
#include "components/policy/core/common/policy_types.h"
@@ -172,7 +173,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD, value.CreateDeepCopy(), nullptr);
store_->SetCurrentPolicy(policies);
- loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Notify when new policies are added.
@@ -188,7 +189,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
policy::POLICY_SOURCE_CLOUD, value.CreateDeepCopy(), nullptr);
store_->SetCurrentPolicy(policies);
- loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Notify when policies change.
@@ -207,7 +208,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
policy::POLICY_SOURCE_CLOUD, new_value.CreateDeepCopy(),
nullptr);
store_->SetCurrentPolicy(policies);
- loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Notify when policies are removed.
@@ -223,13 +224,13 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
policies.Erase("bbb");
store_->SetCurrentPolicy(policies);
- loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
// Don't notify when there aren't any changes.
EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
store_->SetCurrentPolicy(policies);
- loop_.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
Mock::VerifyAndClearExpectations(&observer_);
}

Powered by Google App Engine
This is Rietveld 408576698