chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc - Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

index 256577d233d72a66db26e7e09e8e0bf52af6c12c..86955da31b0ab764027731b7e21730223cdf4612 100644

--- a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

+++ b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

@@ -15,6 +15,7 @@

#include "base/containers/hash_tables.h"

#include "base/location.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/string16.h"

#include "base/strings/stringprintf.h"

@@ -102,7 +103,7 @@ class PhishingTermFeatureExtractorTest : public ::testing::Test {

shingle_hashes,

base::Bind(&PhishingTermFeatureExtractorTest::ExtractionDone,

base::Unretained(this)));

- msg_loop_.Run();

+ base::RunLoop().Run();

return success_;

}

@@ -118,7 +119,7 @@ class PhishingTermFeatureExtractorTest : public ::testing::Test {

msg_loop_.task_runner()->PostTask(

FROM_HERE, base::Bind(&PhishingTermFeatureExtractorTest::QuitExtraction,

base::Unretained(this)));

- msg_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

// Completion callback for feature extraction.