chrome/browser/extensions/extension_action_icon_factory_unittest.cc - Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_icon_factory_unittest.cc

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/app_data_migrator_unittest.cc ('k') | chrome/browser/extensions/extension_icon_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_icon_factory_unittest.cc

diff --git a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

index 351b25b9d0e44a019881460edfc514142165b26a..59a778d6bf88b0b6eac5f2eec3b9b43be2a40851 100644

--- a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

+++ b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

@@ -12,6 +12,7 @@

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

#include "base/path_service.h"

+#include "base/run_loop.h"

#include "build/build_config.h"

#include "chrome/browser/extensions/extension_action.h"

#include "chrome/browser/extensions/extension_action_manager.h"

@@ -98,7 +99,7 @@ class ExtensionActionIconFactoryTest

void WaitForIconUpdate() {

quit_in_icon_updated_ = true;

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

quit_in_icon_updated_ = false;

}

@@ -151,7 +152,7 @@ class ExtensionActionIconFactoryTest

void TearDown() override {

material_design_state_.reset();

profile_.reset(); // Get all DeleteSoon calls sent to ui_loop_.

- ui_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

// ExtensionActionIconFactory::Observer overrides: