chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/top_sites/top_sites_apitest.cc ('k') | chrome/browser/extensions/app_data_migrator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 07a88e4723b4ba43509c761dedf4d3186281ef56..1e75bb5b488ec4407b458751ceb4db0f8c80f36c 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -295,7 +295,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceRedirect) {

request->identifier(), response));

request->Start();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(!request->is_pending());

EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());

@@ -346,7 +346,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceRedirect) {

request2->identifier(), response));

request2->Start();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(!request2->is_pending());

EXPECT_EQ(net::URLRequestStatus::SUCCESS, request2->status().status());

@@ -411,7 +411,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceCancel) {

request->Start();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(!request->is_pending());

EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());

@@ -473,7 +473,7 @@ TEST_F(ExtensionWebRequestTest, SimulateChancelWhileBlocked) {

request->Start();

// request->Start() will have submitted OnBeforeRequest by the time we cancel.

request->Cancel();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(!request->is_pending());

EXPECT_EQ(net::URLRequestStatus::CANCELED, request->status().status());

@@ -984,7 +984,7 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {

// exists and are therefore not listed in the responses. This makes

// them seem deleted.

request->Start();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(!request->is_pending());

// This cannot succeed as we send the request to a server that does not exist.