chrome/browser/external_protocol/external_protocol_handler_unittest.cc - Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_web_ui_unittest.cc ('k') | chrome/browser/importer/firefox_importer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

index 41703eef035e67f5ad58520f0c1ccd20409d929a..4003a4e9c10bedfe4f5bc92d1a5eacf3badd56a9 100644

--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/external_protocol/external_protocol_handler.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "content/public/test/test_browser_thread.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -130,7 +131,7 @@ class ExternalProtocolHandlerTest : public testing::Test {

ExternalProtocolHandler::LaunchUrlWithDelegate(

url, 0, 0, ui::PAGE_TRANSITION_LINK, true, &delegate_);

if (block_state != ExternalProtocolHandler::BLOCK)

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

ASSERT_EQ(should_prompt, delegate_.has_prompted());

ASSERT_EQ(should_launch, delegate_.has_launched());

« no previous file with comments | « chrome/browser/extensions/extension_web_ui_unittest.cc ('k') | chrome/browser/importer/firefox_importer_browsertest.cc » ('j') | no next file with comments »